Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use-headings-to-show-hierarchical-relationships-of-content.por… #29881

Merged
merged 1 commit into from May 26, 2019
Merged

Update use-headings-to-show-hierarchical-relationships-of-content.por… #29881

merged 1 commit into from May 26, 2019

Conversation

sssvander
Copy link
Contributor

@sssvander sssvander commented Oct 26, 2018 •
edited

…tuguese.md

Review in text. Semantic correction to make sense in Portuguese.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@sssvander
Update use-headings-to-show-hierarchical-relationships-of-content.por…
f019b5d 
…tuguese.md

Review in text. Semantic correction to make sense in Portuguese.
@camperbot camperbot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: need to test locally labels Nov 13, 2018
@RandellDawson RandellDawson reopened this Nov 27, 2018
@RandellDawson
Copy link
Member

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@RandellDawson
Copy link
Member

@freeCodeCamp/portuguese-language-editors Can we get this PR reviewed to validate that the translation matches the current English version of the challenge? Thank you.

RandellDawson
RandellDawson approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandellDawson RandellDawson merged commit 17f6a75 into freeCodeCamp:master May 26, 2019
@RandellDawson
Copy link
Member

Congrats @sssvander on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sssvander @RandellDawson @camperbot @greggubarev