fix: sent to local repo in error #31165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file introduces flex-grow: with screen shots and code samples. As with all of my commits, this is a proper contribution effort, neither copy & paste nor a links list.
Added title: 'Flex Grow' to avoid Travis CL no frontmatter error.
Added labels to the code blocks.
Added <code></code> tags to individual code items. Sorry for so many commits. I just saw the styling guide.
Create index.md
* Create flexbox-display-flex.md This file introduces the concept of display:flex and flex-direction:[row | column]. * Rename guide/english/css/flexbox-display-flex.md to guide/english/css/flexbox-display-flex/index.md Changed the folder structure to comply with index.md. * Update index.md Added title: Display Flex to avoid Travice CL no frontmatter error. * Update index.md Added labels to the code blocks. * fix: update individual code items. Added <code></code> tags to individual code items. Sorry for so many commits. I just saw the styling guide.
* Create index.md This file contains details about flex-basis, with screenshots and code samples. As with all of my commits, this is my own work not copy & paste or a lazy linkathon. * Update index.md Added the title; Flex Basis, to avoid Travis CI no frontmatter error. * Update index.md Added labels to the code blocks. * fix: added labels for code items Added <code></code> labels to individual code items. Sorry for all of the commits. I just saw the styling guide. Doing my own QC.
|
It looks like more than one file was submitted. They are self-produced about flexbox. I pulled them to my local freecodecamp repo in error. Some of the files have several commits because I didn't realise that files had to be index.md and that code needed particular formatting. |
|
Okay. Thanks, Tom. |
|
Hey @leebut - not sure if you started modifying these yet. But I thought I could add some more details on what to do here. I'm not sure exactly what to do yet, but It looks like you spent some time on these and I would love to just be able to merge them. We do want to avoid duplicate articles, so we definitely want to either merge these with what we have already. Or possibly just replace what we have with these if they're significantly better. I didn't look through them thoroughly before, so I'm not sure on that. And as far as the images go, we may be able to make an exception here since visuals are really helpful when talking about flexbox. I can take a closer look at some point in the near future and possibly give a better plan - and maybe get some input from someone else. Or if you had something in mind you can let us know or just make the changes. |
|
Yea, I don't know what to tell ya here @leebut - the articles we have are okay. There's definitely some issues with them, but they aren't bad. These seem about the same - perhaps the |
|
Not to worry, Tom. I enjoyed writing them, which also helped me to consolidate my knowledge. At the time I didn't realise there were already articles present. Thank you for your input. |
QuincyLarson
approved these changes
Jul 19, 2019
|
@QuincyLarson Thank you. I'm just happy to have learned something and be able to pass it on. |
six9
added a commit
to six9/freeCodeCamp
that referenced
this pull request
Jul 23, 2019
* Azuzunaga patch 1 (freeCodeCamp#21023) * Add missing command and iTerm2 section * Consolidate changes * Update index.md (freeCodeCamp#36453) * Added CSS logo (freeCodeCamp#24252) * Fix command line guides in spanish (freeCodeCamp#24758) * Add missing command and iTerm2 section * Fix translation, grammar, actually translate a chunk Also fix formatting and make text more conversational. * Jump search Code in Java (freeCodeCamp#30962) Code for Jump Search in Java. * Added content to stub (freeCodeCamp#34325) Added definitions and examples * BFS in Java (freeCodeCamp#35027) Code for implementation of Breadth-First-Search in Java. * Added info; Fixed formatting; (freeCodeCamp#36329) Added note on Scope Fixed formatting of example and added better way to rewrite example. * add informations about queries in graphql (freeCodeCamp#36428) * Update index.md (freeCodeCamp#36349) Removed some statements talking about the optimization potential of goto (which is mentioned but never specified), and I gave a possible use-case for goto followed by some constructs that can replace it, and ended on why goto is discouraged in C++ Added information about the memory behaviour of labels, the syntax to create a label, and where a label can actually be placed (within the same function). * Update index.md (freeCodeCamp#36458) * docs: replace Medium with fCC News (freeCodeCamp#36456) * docs: replace Medium with fCC News (freeCodeCamp#36455) * docs: replace Medium with fCC News (freeCodeCamp#36454) * fix: Update docs, recommending install all packages (freeCodeCamp#36352) * feat(client): add prev next btns to lessons (freeCodeCamp#35485) * feat/add-prev-next-btns-to-lessons redirect to learn instead of home * fix/button-css-properties * fix/change-buttons-to-suggested * fix/add-tests+change-button-to-link Co-authored-by: ojeytonwilliams ojeytonwilliams@gmail.com * Revert "fix/add-tests+change-button-to-link" This reverts commit ae26504. * fix/add-tests+change-button-to-link Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com> * made semi-colon on basic-javascript challenge optional. (freeCodeCamp#36465) * made closing operator optional. * truncated unnecessary regex * Minor edits for clarity. (freeCodeCamp#25841) Edits for clarity and for grammar. * Update a solution for "Find the Symmetric Difference" algorithm (freeCodeCamp#36379) * Update advanced solution * Replace HTML links with markdown syntax * Remove obsolete sort() * Use spread operator instead of Array.from * fix: Init test output on backend challenges Makes sure the test output console is initialized on backend as well as classic challenges. Previously it was tied to SidePanel which was not always present. * fix: Refactor challenge mounting and updating componentDidMount and componentDidUpdate share a lot of code. This just DRYs them out. * fix: Remove non-functional css * feat: Lint curriculum, including test yaml * fix: Only lint staged files on commit * fix: Add tests for the linter * feat: Add scripts to format and lint with prettier * feat: Add rule checking Prism languages The linter now checks that fences have languages and that those languages are supported by PrismJS. The linter has been extended over the guide with its own set of rules that only validate code fences. * fix(tools): Restrict prettier to css * fix(tools): Relax rules for the guide * fix(tools): Correct broken test * fix(curriculum): added extra line before </section> tag - Engl… (freeCodeCamp#36278) * fix(curriculum): format challenge markdown as per linting rules (freeCodeCamp#36326) * fix: Format challenge markdown according to linting rules * fix: Put spaces after section tags * fix: remove guide linting and fix failing challenges * fix: prettify css * update translation bubble-sort (freeCodeCamp#36459) * update translation bubble-sort add examples code * update: two-space indentation for all code * Outputing an "auto" variable (freeCodeCamp#31263) * fix: sent to local repo in error (freeCodeCamp#31165) * Create index.md This file introduces flex-grow: with screen shots and code samples. As with all of my commits, this is a proper contribution effort, neither copy & paste nor a links list. * Update index.md Added title: 'Flex Grow' to avoid Travis CL no frontmatter error. * Update index.md Added labels to the code blocks. * fix: updated individual code items & sentences Added <code></code> tags to individual code items. Sorry for so many commits. I just saw the styling guide. * Create flexbox-display-flex.md (freeCodeCamp#2) * Create flexbox-display-flex.md This file introduces the concept of display:flex and flex-direction:[row | column]. * Rename guide/english/css/flexbox-display-flex.md to guide/english/css/flexbox-display-flex/index.md Changed the folder structure to comply with index.md. * Update index.md Added title: Display Flex to avoid Travice CL no frontmatter error. * Update index.md Added labels to the code blocks. * fix: update individual code items. Added <code></code> tags to individual code items. Sorry for so many commits. I just saw the styling guide. * Create index.md (freeCodeCamp#4) * Create index.md This file contains details about flex-basis, with screenshots and code samples. As with all of my commits, this is my own work not copy & paste or a lazy linkathon. * Update index.md Added the title; Flex Basis, to avoid Travis CI no frontmatter error. * Update index.md Added labels to the code blocks. * fix: added labels for code items Added <code></code> labels to individual code items. Sorry for all of the commits. I just saw the styling guide. Doing my own QC. * Added the nltk library installation. (freeCodeCamp#31603) * Added the nltk library installation. * Address feedback * Add ES6 syntax to Challenge' solution (freeCodeCamp#36367) * ES6 syntax Added ES6 syntax to challenge' solution. * Add ES6 solution to challenge An optional way to solve the challenge using ES6 arrow functions * content(guide): add blockchain-development article (freeCodeCamp#36256) * Create index.md * Update index.md * Update index.md * Update index.md * Update index.md * added small entry for docker exec (freeCodeCamp#33989) there's so much missing here (qwq) * order point included (freeCodeCamp#33548) * Add list article (freeCodeCamp#35018) * feat(guide): added java implementation to quicksort (freeCodeCamp#36005) * feat: added java implementation to quicksort * fix: edited heading in quicksort * feat: added java implementation for red-black trees (freeCodeCamp#36026) * feat: Add guide article and update its challenge (freeCodeCamp#36371) * feat: Add guide article and update its challenge * Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * fix: Stop hints from being hidden * fix: Improve the wording. * Update index.md Fixed per suggestion * Update index.md Fixed per suggestion * feat: Add article for Elixir Keyword Lists (freeCodeCamp#36141) * Really elaborating on the network topic to be nearly all inclusive (freeCodeCamp#36140) This might be better put in a topic separate from C, its own topic, since the network socket interface is accessible in Java, C#, Python, PHP, NodeJS, etc. . Since the socket api is written in C itself, the system calls, and most languages will use these same C system calls, I think it still works to offer the main explanation in C, then either have an example server and client in every language PHP, Ruby, Java, C#, Obj-C, etc * Support Vector Machine index updated. (freeCodeCamp#33509) Added multiple sections in the index page of support vector machine. * Added the topic Evaluating the clustering (freeCodeCamp#35855) * Added the topic Evaluating the clustering How can we evaluate the clustering algorithms, based on analyzing our results. * Fixed grammar and put in second person * Add notes on when Erlang began and became Open Source. (freeCodeCamp#33270) * Update index.md (freeCodeCamp#33013) * add functional-language/index.md (freeCodeCamp#33258) A summary of the functional programming features of Erlang and the consequences. * add pure-functions/index.md (freeCodeCamp#32887) A description of the important of pure functions and their limitations in Erlang * added details for crossfilter.js (freeCodeCamp#32677) Added brief details and setup instructions for crossfilter.js * add shell/index.md (freeCodeCamp#32378) Description of the Erlang shell and how to use it as a simple interpreter. * add names/index.md (freeCodeCamp#32398) Notes on names that begin with an upper case letter and those that don't and naming conventions. * Update index.md (freeCodeCamp#32348) Added details to description of NP completeness. * Added optimization algorithms for Gradient Descent (freeCodeCamp#32096) * Contribution on the topic. (freeCodeCamp#31767) * Contribution on the topic. Added some basic information on the concept of Multi Layer Perceptron. Added an image for better understanding of the concept. * Added extra information. Check out the following piece of data on MLP. * Update index.md * Update index.md * Grammatical changes (freeCodeCamp#32856) i changes two verbs that maybe were too unsuitable to code. * Added install instructions for Arch Linux (freeCodeCamp#30830) * Added new section (freeCodeCamp#28311) Added new section about getting the message inside an exception * Add Section on Docker CE for Linux and Install guide in index.md (freeCodeCamp#27351) * Create index.md Installation and Setup guide for Docker CE on Linux. * Rename guide/english/linux/install-and-Setup-DockerCE-in-linux/index.md to guide/english/linux/install-and-setup-dockerce-in-linux/index.md * add `map` function to haskell section (freeCodeCamp#25718) Add `map` function to haskell section of guide.freecodecamp.org * Updated Data-Drive Design content (freeCodeCamp#33449) * Updated Data-Drive Design content Added detailed introduction to Data Driven Design. What, Why, and How of the subject and also added tools and resources for the same. * Update index.md * Fix typos * fix(docs): minor SPG changes * fix(mathjax): prevent load in offline mode * chore(root): update dependencies to latest * fix: rename challenge md parser to correct casing * fix: create lockfiles for audits * fix(parser): bump version and publish * chore(client): resolve linting errors in client * fix: use rounding to fix floating point comparison * chore(client): update dependencies except gatsby * fix(client): apply type errors from code review Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * Add solution to hint stub (mongoDB model.findById) (freeCodeCamp#36494) * Add solution to hint stub (mongoDB model.findById) * Use callback in `createAndSavePerson()` * Replace stub for mongDB lesson (use model.findOne) (freeCodeCamp#36493) * Replace stub for mongDB lesson (use model.findOne) Add solution * Use callback in `createAndSavePerson()` * Replace stub for mongoDB lesson (use model.find) (freeCodeCamp#36491) * Replace stub for mongoDB lesson * Replace stub for "Use model.find to search your database" * Include hints * Include solution * Use callback in `createAndSavePerson()` * fix: corrected hints syntax * Replace stub for mongoDB lesson (create many records) (freeCodeCamp#36492) * Replace stub with hints and solution For "create many records" mongoDB lesson * Fix markdown for inline code Add new line to allow markdown to render inline code * Use callback in `createAndSavePerson` function * fix: corrected hints syntax * Replace stub with hints and code solution (freeCodeCamp#36487) * Replace stub with hints and code solution * Change spoiler tag text Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update `createAndSavePerson` to use callback Previous solution had an empty callback * fix: added hint header * Add hints for "install and set up mongoose" (freeCodeCamp#36474) * Add hints for "install and set up mongoose" * Add hint for how to solve the timeout error * Add hint for what to put in the `.env` file * Add code snippets for `.env`, `package.json` and `myApp.js` * Restructure hints and headers * Remove code solution from timeout hint * Restructure headers to match the new hint template * Move hint subject below the header Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Move hint subject below the header Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update text in spoiler tag Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update text in spoiler tag Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update text in spoiler tag Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Add javascript tag to code block Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Move first line of code below ``` Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Remove placeholder text Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Add json tag to code block Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Remove redundant sentence Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Format solutions section and hint * Replace tabs with 2 space indents in `package.json` * Remove the spoiler tags from each file name * Remove placeholder comments in `myApp.js` to make it easier to read the code * Update sentence in hint as two words were not displaying * fix(docs): npm run commit has been removed (freeCodeCamp#36451) * fix(docs): npm run commit has been removed * fix(docs): using `npm ci` makes more sense for bootstrapping Signed-off-by: Jonathan <theflametrooper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index.md)masterbranch of freeCodeCamp.If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX