Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing Waypoint: Write Reusable JavaScript with Functions #3287

Merged
merged 3 commits into from
Sep 14, 2015
Merged

Fix confusing Waypoint: Write Reusable JavaScript with Functions #3287

merged 3 commits into from
Sep 14, 2015

Conversation

joel-bentley
Copy link
Contributor

Fix confusing description and examples.

Remove superfluous and unneeded tests. For example,

editor.getValue().match(/return/gi).length >= 1

will always be true. The regex matches all instances of the string "return" in the code window, even the instance in the comments within the code.

closes #1936

@QuincyLarson
Copy link
Contributor

Great work here, @joel-bentley! If you can spare the time to look at our other JavaScript and and OOP challenges, they could use a similar touch, too.

QuincyLarson added a commit that referenced this pull request Sep 14, 2015
Fix confusing Waypoint: Write Reusable JavaScript with Functions
@QuincyLarson QuincyLarson merged commit 01608ed into freeCodeCamp:staging Sep 14, 2015
@joel-bentley
Copy link
Contributor Author

Thanks @QuincyLarson !
I'll take a look and see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants