Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed '/' from Link #32902

Merged
merged 1 commit into from
Nov 29, 2018
Merged

removed '/' from Link #32902

merged 1 commit into from
Nov 29, 2018

Conversation

AkshayBabbar
Copy link
Contributor

'/' was linking to the wrong link. Updated please review

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@AkshayBabbar
removed '/' from Link
a87f228 
'/' was linking to the wrong link. Updated please review
@RandellDawson RandellDawson added the invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's label Oct 30, 2018
@AkshayBabbar
Copy link
Contributor Author

Please provide REASON

@AkshayBabbar AkshayBabbar reopened this Oct 30, 2018
@Manish-Giri Manish-Giri removed the invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's label Oct 30, 2018
@Manish-Giri
Copy link
Contributor

LGTM 👍

@AkshayBabbar
Copy link
Contributor Author

LGTM 👍

can you please check other also since they have been marked invalid.

@QuincyLarson
Copy link
Contributor

@RandellDawson I agree with @Manish-Giri - This PR does seem to fix a broken link (the https://en.wikipedia.org/wiki/Rabin%E2%80%93Karp_algorithm/ link with the trailing slash doesn't work on Wikipedia for some reason).

@RandellDawson
Copy link
Member

@QuincyLarson I labeled it invalid, because it was a self-closure at the time I saw it.

@Manish-Giri Manish-Giri self-assigned this Nov 9, 2018
@Manish-Giri Manish-Giri closed this Nov 9, 2018
@Manish-Giri Manish-Giri reopened this Nov 9, 2018
Manish-Giri
Manish-Giri approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@Manish-Giri Manish-Giri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AkshayBabbar

Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍 We're happy to accept these changes and look forward to future contributions. 📝

@Manish-Giri Manish-Giri merged commit 1e288d7 into freeCodeCamp:master Nov 29, 2018
@AkshayBabbar
Copy link
Contributor Author

Thanks @Manish-Giri will surely look forward to involve more in FreeCodeCamp. 👍

Bouncey pushed a commit to Bouncey/freeCodeCamp that referenced this pull request Nov 29, 2018
@AkshayBabbar @Bouncey
removed '/' from Link (freeCodeCamp#32902)
2838c11 
'/' was linking to the wrong link. Updated please review
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@yuhonghong66 yuhonghong66 mentioned this pull request Feb 11, 2024
Open
@SC0T1ISHNiNjA SC0T1ISHNiNjA mentioned this pull request Feb 11, 2024
Open
@ramsemune ramsemune mentioned this pull request Feb 12, 2024
Open
@zzx4998 zzx4998 mentioned this pull request Feb 12, 2024
Open
@shaffiqv shaffiqv mentioned this pull request Feb 12, 2024
Open
@12btcse1108 12btcse1108 mentioned this pull request Feb 12, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Feb 12, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Feb 12, 2024
Open
@ramsemune ramsemune mentioned this pull request Mar 22, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Mar 22, 2024
Open
@zzx4998 zzx4998 mentioned this pull request Mar 22, 2024
Open
@12btcse1108 12btcse1108 mentioned this pull request Mar 22, 2024
Open
@shaffiqv shaffiqv mentioned this pull request Mar 22, 2024
Open
@yuhonghong66 yuhonghong66 mentioned this pull request Mar 22, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 22, 2024
Open
@SC0T1ISHNiNjA SC0T1ISHNiNjA mentioned this pull request Mar 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Mar 23, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 13, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 13, 2024
Open
@SC0T1ISHNiNjA SC0T1ISHNiNjA mentioned this pull request May 14, 2024
Open
@yuhonghong66 yuhonghong66 mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 20, 2024
Open
@yuhonghong66 yuhonghong66 mentioned this pull request May 21, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request May 21, 2024
Open
@ramsemune ramsemune mentioned this pull request May 21, 2024
Open
@SC0T1ISHNiNjA SC0T1ISHNiNjA mentioned this pull request May 21, 2024
Open
@12btcse1108 12btcse1108 mentioned this pull request May 21, 2024
Open
@shaffiqv shaffiqv mentioned this pull request May 21, 2024
Open
@zzx4998 zzx4998 mentioned this pull request May 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manish-Giri Manish-Giri Manish-Giri approved these changes

Assignees

@Manish-Giri Manish-Giri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AkshayBabbar @Manish-Giri @QuincyLarson @RandellDawson @camperbot