Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch challenges #34376

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Nov 18, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@ValeraS ValeraS added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels Nov 18, 2018
@ValeraS ValeraS requested review from Bouncey and a team November 18, 2018 18:56
@ValeraS ValeraS changed the title Fix/watch challenges fix: watch challenges Nov 18, 2018
@Bouncey
Copy link
Member

Bouncey commented Nov 22, 2018

I don't think test-challenges is running correctly. There is nothing logged in Travis apart from an empty array, which IIRC is meant to be a list of challenges without a solution.

If I run it locally it just hangs. If I add some catch blocks to the await statments I get the error the run in not a function.

@ValeraS
Copy link
Contributor Author

ValeraS commented Nov 22, 2018

I don't think test-challenges is running correctly. There is nothing logged in Travis apart from an empty array, which IIRC is meant to be a list of challenges without a solution.

What do you mean?
https://travis-ci.org/freeCodeCamp/freeCodeCamp/builds/456686485

image

How do you run tests locally?

@Bouncey
Copy link
Member

Bouncey commented Nov 28, 2018

I have tried both npm test from the project root and cd ./curriculum && npm test

Both hang for the challenge tests. The one directly in the curriculum dir shows the progress bar before it hangs

╭─stuart@MagicalTrevor ~/dev/freecodecamp/curriculum  ‹ValeraS-fix/watch-challenges*›
╰─$ npm test                                                                                                                                                                                              

> @freecodecamp/curriculum@0.0.0-next.4 test /Users/stuart/dev/freecodecamp/curriculum
> mocha --delay --reporter progress --bail


  [․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․]

@Bouncey Bouncey merged commit 36fa426 into freeCodeCamp:master Nov 28, 2018
@ValeraS ValeraS deleted the fix/watch-challenges branch December 3, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants