Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary empty string in basic bonfire params #3565

Closed
wants to merge 3 commits into from
Closed

Fix unnecessary empty string in basic bonfire params #3565

wants to merge 3 commits into from

Conversation

michael-krebs
Copy link
Contributor

No description provided.

@bugron
Copy link
Contributor

bugron commented Oct 2, 2015

@michael-krebs please remove issue number from the title and do git commit --amend to provide more informative name of commit, also change the title to be more informative, thanks.

@michael-krebs michael-krebs changed the title fix #3401 Fix unnecessary empty string in basic bonfire params Oct 2, 2015
@BerkeleyTrue BerkeleyTrue added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Oct 2, 2015
@bugron bugron mentioned this pull request Oct 10, 2015
Merged
@bugron
Copy link
Contributor

bugron commented Oct 10, 2015

@michael-krebs I'm closing this PR because we have another one (#3699) already merged. Thanks for contribution.

@bugron bugron closed this Oct 10, 2015
@bugron bugron removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Oct 10, 2015
@joseroubert08 joseroubert08 mentioned this pull request Apr 27, 2022
Open
@bobby-lin bobby-lin mentioned this pull request Apr 27, 2022
Open
@harunpehlivan harunpehlivan mentioned this pull request Apr 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2022
Open
@luizfernandorg luizfernandorg mentioned this pull request Apr 28, 2022
Open
@simha95 simha95 mentioned this pull request Apr 28, 2022
Open
@mconnor mconnor mentioned this pull request Apr 28, 2022
Open
@fcsouza fcsouza mentioned this pull request Apr 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2022
Open
@EvKissle EvKissle mentioned this pull request May 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michael-krebs @bugron @BerkeleyTrue