Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 #36402

Merged
merged 4 commits into from
Jul 24, 2019
Merged

fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 #36402

merged 4 commits into from
Jul 24, 2019

Conversation

RandellDawson
Copy link
Member

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Related to issue #36400

This PR removes assert message arguments from testString for the following sub sections of the JavaScript Algorithms and Data Structures curriculum section:

  • Basic Algorithm Scripting
  • Debugging
  • ES6
  • Functional Programming

@RandellDawson RandellDawson mentioned this pull request Jul 9, 2019
Closed
@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jul 9, 2019
@RandellDawson RandellDawson added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Jul 11, 2019
@RandellDawson RandellDawson force-pushed the fix/remove-unnecessary-assert-message-argument-from-english-challenges-javascript-algorithms-and-data-structures-02 branch from d1c0a3d to 0f29b4c Compare July 11, 2019 00:54
@RandellDawson RandellDawson removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Jul 11, 2019
@raisedadead raisedadead added release: next/beta type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping. labels Jul 23, 2019
@ojeytonwilliams ojeytonwilliams self-assigned this Jul 24, 2019
ojeytonwilliams
ojeytonwilliams approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 5bf8527 into freeCodeCamp:master Jul 24, 2019
@RandellDawson RandellDawson deleted the fix/remove-unnecessary-assert-message-argument-from-english-challenges-javascript-algorithms-and-data-structures-02 branch July 24, 2019 12:31
@12btcse1108 12btcse1108 mentioned this pull request Jun 24, 2023
Open
@12btcse1108 12btcse1108 mentioned this pull request Nov 26, 2023
Open
@thangnguyen2001 thangnguyen2001 mentioned this pull request May 13, 2024
Open
@ramsemune ramsemune mentioned this pull request May 13, 2024
Open
@zzx4998 zzx4998 mentioned this pull request May 13, 2024
Open
@Raj7021 Raj7021 mentioned this pull request May 13, 2024
Open
@AldinSnyk AldinSnyk mentioned this pull request May 13, 2024
Open
@kinguritorisu kinguritorisu mentioned this pull request May 13, 2024
Open
@faizalghazali faizalghazali mentioned this pull request May 14, 2024
Open
@shaffiqv shaffiqv mentioned this pull request May 14, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request May 14, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 14, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request May 14, 2024
Open
@patelpujan28 patelpujan28 mentioned this pull request May 14, 2024
Open
@altsun altsun mentioned this pull request May 14, 2024
Open
@armisnyk armisnyk mentioned this pull request May 14, 2024
Open
@thangnguyen2001 thangnguyen2001 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees

@ojeytonwilliams ojeytonwilliams

Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RandellDawson @ojeytonwilliams @raisedadead @camperbot