fix(curriculum): Remove additional unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures #36439

RandellDawson · 2019-07-10T21:46:48Z

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)
My pull request targets the master branch of freeCodeCamp.
None of my changes are plagiarized from another source without proper attribution.
All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
My changes do not use shortened URLs or affiliate links.

Related to issue #36400

This PR removes assert message arguments from testString for the following sub sections of the JavaScript Algorithms and Data Structures curriculum section. This PR was created to remove assert message arguments which were wrapped in two single quotes instead of single quotes. See this discussion for more information

Basic Algorithm Scripting
Debugging
ES6
Functional Programming
Basic Data Structures
Intermediate Algorithm Scripting
Object Oriented Programming
Regular Expressions
JavaScript Algorithms and Data Structures Projects

vkWeb

@RandellDawson Except for a few files, all the files have message arguments that need to be removed. Please go through all the files once more.

vkWeb · 2019-07-24T20:02:26Z

...sh/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/boo-who.english.md

@@ -31,7 +31,7 @@ tests:
  - text: <code>booWho([].slice)</code> should return false.
    testString: assert.strictEqual(booWho([].slice), false, '<code>booWho([].slice)</code> should return false.');


Fix this file.

vkWeb · 2019-07-24T20:02:51Z

...data-structures/basic-data-structures/access-property-names-with-bracket-notation.english.md

  - text: 'The <code>foods</code> object should have only the following key-value pairs: <code>apples: 25</code>, <code>oranges: 32</code>, <code>plums: 28</code>, <code>bananas: 13</code>, <code>grapes: 35</code>, <code>strawberries: 27</code>'
-    testString: 'assert.deepEqual(foods, {apples: 25, oranges: 32, plums: 28, bananas: 13, grapes: 35, strawberries: 27}, ''The <code>foods</code> object should have only the following key-value pairs: <code>apples: 25</code>, <code>oranges: 32</code>, <code>plums: 28</code>, <code>bananas: 13</code>, <code>grapes: 35</code>, <code>strawberries: 27</code>'');'
+    testString: 'assert.deepEqual(foods, {apples: 25, oranges: 32, plums: 28, bananas: 13, grapes: 35, strawberries: 27});'
  - text: <code>checkInventory("apples")</code> should return <code>25</code>
    testString: assert.strictEqual(checkInventory('apples'), 25, '<code>checkInventory("apples")</code> should return <code>25</code>');


3 arguments in this file.

vkWeb · 2019-07-24T20:04:11Z

...hms-and-data-structures/basic-data-structures/modify-an-array-stored-in-an-object.english.md

@@ -22,7 +22,7 @@ tests:
  - text: The <code>user</code> object has <code>name</code>, <code>age</code>, and <code>data</code> keys
    testString: assert('name' in user && 'age' in user && 'data' in user, 'The <code>user</code> object has <code>name</code>, <code>age</code>, and <code>data</code> keys');


2 arguments in this file.

vkWeb · 2019-07-24T20:05:34Z

...nd-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

@@ -43,7 +43,7 @@ tests:
  - text: The <code>online</code> property nested in the <code>data</code> key of <code>userActivity</code> should be set to <code>45</code>
    testString: assert(userActivity.data.online === 45, 'The <code>online</code> property nested in the <code>data</code> key of <code>userActivity</code> should be set to <code>45</code>');


3 arguments in this file.

vkWeb · 2019-07-24T20:05:50Z

...ructures/basic-data-structures/use-the-delete-keyword-to-remove-object-properties.english.md

@@ -27,7 +27,7 @@ Use the delete keyword to remove the <code>oranges</code>, <code>plums</code>, a
 ```yml
 tests:
  - text: 'The <code>foods</code> object only has three keys: <code>apples</code>, <code>grapes</code>, and <code>bananas</code>'
-    testString: 'assert(!foods.hasOwnProperty(''oranges'') && !foods.hasOwnProperty(''plums'') && !foods.hasOwnProperty(''strawberries'') && Object.keys(foods).length === 3, ''The <code>foods</code> object only has three keys: <code>apples</code>, <code>grapes</code>, and <code>bananas</code>'');'
+    testString: 'assert(!foods.hasOwnProperty(''oranges'') && !foods.hasOwnProperty(''plums'') && !foods.hasOwnProperty(''strawberries'') && Object.keys(foods).length === 3);'
  - text: The <code>oranges</code>, <code>plums</code>, and <code>strawberries</code> keys are removed using <code>delete</code>
    testString: assert(code.search(/oranges:/) !== -1 && code.search(/plums:/) !== -1 && code.search(/strawberries:/) !== -1, 'The <code>oranges</code>, <code>plums</code>, and <code>strawberries</code> keys are removed using <code>delete</code>');


This one here.

vkWeb · 2019-07-24T20:12:25Z

...a-structures/object-oriented-programming/extend-constructors-to-receive-arguments.english.md

@@ -52,7 +52,7 @@ tests:
  - text: <code>Dog</code> should receive an argument for <code>name</code>.
    testString: assert((new Dog('Clifford')).name === 'Clifford', '<code>Dog</code> should receive an argument for <code>name</code>.');


3 arguments.

vkWeb · 2019-07-24T20:13:14Z

...vascript-algorithms-and-data-structures/regular-expressions/match-all-non-numbers.english.md

@@ -35,7 +35,7 @@ tests:
  - text: Your regex should find 12 non-digits in <code>"21 Jump Street"</code>.
    testString: assert("21 Jump Street".match(noNumRegex).length == 12, 'Your regex should find 12 non-digits in <code>"21 Jump Street"</code>.');


A lot of arguments found.

vkWeb · 2019-07-24T20:13:38Z

...2-javascript-algorithms-and-data-structures/regular-expressions/match-all-numbers.english.md

@@ -35,7 +35,7 @@ tests:
  - text: Your regex should find 2 digits in <code>"21 Jump Street"</code>.
    testString: assert("21 Jump Street".match(numRegex).length == 2, 'Your regex should find 2 digits in <code>"21 Jump Street"</code>.');


A lot of arguments here too.

vkWeb · 2019-07-24T20:14:07Z

...lgorithms-and-data-structures/regular-expressions/match-non-whitespace-characters.english.md

@@ -34,7 +34,7 @@ tests:
  - text: Your regex should find 35 non-spaces in <code>"Men are from Mars and women are from Venus."</code>
    testString: assert("Men are from Mars and women are from Venus.".match(countNonWhiteSpace).length == 35, 'Your regex should find 35 non-spaces in <code>"Men are from Mars and women are from Venus."</code>');
  - text: 'Your regex should find 23 non-spaces in <code>"Space: the final frontier."</code>'
-    testString: 'assert("Space: the final frontier.".match(countNonWhiteSpace).length == 23, ''Your regex should find 23 non-spaces in <code>"Space: the final frontier."</code>'');'
+    testString: 'assert("Space: the final frontier.".match(countNonWhiteSpace).length == 23);'
  - text: Your regex should find 21 non-spaces in <code>"MindYourPersonalSpace"</code>
    testString: assert("MindYourPersonalSpace".match(countNonWhiteSpace).length == 21, 'Your regex should find 21 non-spaces in <code>"MindYourPersonalSpace"</code>');


4 arguments.

vkWeb · 2019-07-24T20:14:35Z

...02-javascript-algorithms-and-data-structures/regular-expressions/match-whitespace.english.md

@@ -35,7 +35,7 @@ tests:
  - text: Your regex should find eight spaces in <code>"Men are from Mars and women are from Venus."</code>
    testString: assert("Men are from Mars and women are from Venus.".match(countWhiteSpace).length == 8, 'Your regex should find eight spaces in <code>"Men are from Mars and women are from Venus."</code>');
  - text: 'Your regex should find three spaces in <code>"Space: the final frontier."</code>'
-    testString: 'assert("Space: the final frontier.".match(countWhiteSpace).length == 3, ''Your regex should find three spaces in <code>"Space: the final frontier."</code>'');'
+    testString: 'assert("Space: the final frontier.".match(countWhiteSpace).length == 3);'
  - text: Your regex should find no spaces in <code>"MindYourPersonalSpace"</code>
    testString: assert("MindYourPersonalSpace".match(countWhiteSpace) == null, 'Your regex should find no spaces in <code>"MindYourPersonalSpace"</code>');


4 arguments.

RandellDawson · 2019-07-25T00:00:51Z

@vkWeb This PR actually is an extra PR which removed arguments which were missed in the series of other PRs for the JavaScript Algorithm and Data Structures section. This PR only will contain fixes which were missed in the earlier PRs.

Note to Mods: For any mods reviewing any PR in this series where the title starts with "Remove additional ...", you will encounter what @vkWeb has described here. You just will have to trust the earlier PRs removed the other lines. Remember, if an argument is left in, it is not an actual issue. This series of PRs was just meant to remove 99% of the unnecessary assert message arguments.

We can wait to merge this one after all the others have been merged and then I will rebase this one against master and then we can see if any changes are still necessary. I will temporarily add the blocked label until the others have been merged.

vkWeb · 2019-07-25T12:42:27Z

@RandellDawson Ohh. Okay, I'll give this one a quick look after rebase.

thecodingaviator · 2019-07-27T15:56:59Z

This is the only such PR left now @RandellDawson

thecodingaviator

LGTM

thecodingaviator · 2019-07-28T04:17:04Z

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

RandellDawson force-pushed the fix/remove-unnecessary-assert-mesage-argument-from-various-javascript-algorithms-and-data-structures-challenges branch from e7ac1a5 to d07d240 Compare July 10, 2019 21:51

camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jul 10, 2019

RandellDawson force-pushed the fix/remove-unnecessary-assert-mesage-argument-from-various-javascript-algorithms-and-data-structures-challenges branch from d07d240 to fcde0cd Compare July 12, 2019 18:04

raisedadead added release: next/beta type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping. labels Jul 23, 2019

vkWeb suggested changes Jul 24, 2019

View reviewed changes

RandellDawson added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jul 25, 2019

RandellDawson force-pushed the fix/remove-unnecessary-assert-mesage-argument-from-various-javascript-algorithms-and-data-structures-challenges branch from fcde0cd to e88e795 Compare July 27, 2019 23:37

RandellDawson removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jul 27, 2019

fix: removed more assert msg arguments

a85a540

RandellDawson force-pushed the fix/remove-unnecessary-assert-mesage-argument-from-various-javascript-algorithms-and-data-structures-challenges branch from 07a9a97 to a85a540 Compare July 28, 2019 03:37

thecodingaviator approved these changes Jul 28, 2019

View reviewed changes

thecodingaviator merged commit ba6ae71 into freeCodeCamp:master Jul 28, 2019

RandellDawson deleted the fix/remove-unnecessary-assert-mesage-argument-from-various-javascript-algorithms-and-data-structures-challenges branch July 28, 2019 04:27

12btcse1108 mentioned this pull request Jun 24, 2023

[Snyk] Fix for 1 vulnerabilities 12btcse1108/freeCodeCamp#12

Open

12btcse1108 mentioned this pull request Nov 26, 2023

[Snyk] Fix for 26 vulnerabilities 12btcse1108/freeCodeCamp#26

Open

thangnguyen2001 mentioned this pull request May 13, 2024

[Snyk] Fix for 1 vulnerabilities thangnguyen2001/freeCodeCamp#151

Open

ramsemune mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities ramsemune/freeCodeCamp#145

Open

zzx4998 mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities zzx4998/freeCodeCamp#145

Open

Raj7021 mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities Raj7021/freeCodeCamp#119

Open

AldinSnyk mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities AldinSnyk/freeCodeCampTEST#30

Open

kinguritorisu mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities kinguritorisu/freeCodeCamp#27

Open

faizalghazali mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities faizalghazali/freeCodeCamp#149

Open

shaffiqv mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities shaffiqv/freeCodeCamp#103

Open

kevinjm39 mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities kevinjm39/freeCodeCamp#1139

Open

MaxMood96 mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities MaxMood96/freeCodeCamp#152

Open

kevinjm39 mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities kevinjm39/freeCodeCamp#1140

Open

patelpujan28 mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities patelpujan28/freeCodeCamp#27

Open

altsun mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities altsun/freeCodeCamp#8

Open

armisnyk mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities armisnyk/freeCodeCamp#17

Open

thangnguyen2001 mentioned this pull request May 14, 2024

[Snyk] Fix for 1 vulnerabilities thangnguyen2001/freeCodeCamp#152

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(curriculum): Remove additional unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures #36439

fix(curriculum): Remove additional unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures #36439

RandellDawson commented Jul 10, 2019

vkWeb left a comment

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

vkWeb Jul 24, 2019

RandellDawson commented Jul 25, 2019 •

edited

Loading

vkWeb commented Jul 25, 2019

thecodingaviator commented Jul 27, 2019

thecodingaviator left a comment

thecodingaviator commented Jul 28, 2019

		@@ -31,7 +31,7 @@ tests:
		- text: <code>booWho([].slice)</code> should return false.
		testString: assert.strictEqual(booWho([].slice), false, '<code>booWho([].slice)</code> should return false.');

		@@ -22,7 +22,7 @@ tests:
		- text: The <code>user</code> object has <code>name</code>, <code>age</code>, and <code>data</code> keys
		testString: assert('name' in user && 'age' in user && 'data' in user, 'The <code>user</code> object has <code>name</code>, <code>age</code>, and <code>data</code> keys');

		@@ -43,7 +43,7 @@ tests:
		- text: The <code>online</code> property nested in the <code>data</code> key of <code>userActivity</code> should be set to <code>45</code>
		testString: assert(userActivity.data.online === 45, 'The <code>online</code> property nested in the <code>data</code> key of <code>userActivity</code> should be set to <code>45</code>');

		@@ -52,7 +52,7 @@ tests:
		- text: <code>Dog</code> should receive an argument for <code>name</code>.
		testString: assert((new Dog('Clifford')).name === 'Clifford', '<code>Dog</code> should receive an argument for <code>name</code>.');

		@@ -35,7 +35,7 @@ tests:
		- text: Your regex should find 12 non-digits in <code>"21 Jump Street"</code>.
		testString: assert("21 Jump Street".match(noNumRegex).length == 12, 'Your regex should find 12 non-digits in <code>"21 Jump Street"</code>.');

		@@ -35,7 +35,7 @@ tests:
		- text: Your regex should find 2 digits in <code>"21 Jump Street"</code>.
		testString: assert("21 Jump Street".match(numRegex).length == 2, 'Your regex should find 2 digits in <code>"21 Jump Street"</code>.');

fix(curriculum): Remove additional unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures #36439

fix(curriculum): Remove additional unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures #36439

Conversation

RandellDawson commented Jul 10, 2019

vkWeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RandellDawson commented Jul 25, 2019 • edited Loading

vkWeb commented Jul 25, 2019

thecodingaviator commented Jul 27, 2019

thecodingaviator left a comment

Choose a reason for hiding this comment

thecodingaviator commented Jul 28, 2019

RandellDawson commented Jul 25, 2019 •

edited

Loading