Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): modal a11y and learn tabs on mobile #36750

Merged
merged 3 commits into from
Sep 4, 2019
Merged

fix(client): modal a11y and learn tabs on mobile #36750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
090cb16
fix/ make modal more visible and adjust learn tabs on mob
ahmaxed Sep 3, 2019
773eaa2
fix: clean up
ahmaxed Sep 3, 2019
bdf0767
fix: update snapshot
ahmaxed Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/Footer/Footer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'jest-dom/extend-expect';
import Footer from './';

describe('<Footer />', () => {
it('renders to the DOM', () => {
it('matches snapshot', () => {
const tree = renderer.create(<Footer />).toJSON();
expect(tree).toMatchSnapshot();
});
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/Footer/__snapshots__/Footer.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<Footer /> renders to the DOM 1`] = `
exports[`<Footer /> matches snapshot 1`] = `
<footer
className="site-footer"
>
Expand Down
17 changes: 17 additions & 0 deletions client/src/components/layouts/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,13 @@ a:focus {

.modal-content {
background-color: var(--secondary-background);
border-radius: 0px;
border: 1px solid var(--secondary-color);
}

.modal-footer,
.modal-header {
border-color: var(--secondary-color);
}

/* button */
Expand Down Expand Up @@ -334,3 +341,13 @@ pre {
.panel-primary {
border-color: var(--primary-color);
}

.nav-tabs > li.active > a,
.nav-tabs > li.active > a:hover,
.nav-tabs > li.active > a:focus {
color: var(--secondary-background);
}

.nav-tabs > li > a {
border-radius: 0;
}
6 changes: 6 additions & 0 deletions client/src/templates/Challenges/classic/classic.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@
height: 100%;
overflow: hidden;
}
#challenge-page-tabs a {
text-decoration: none;
}
#challenge-page-tabs a:hover {
color: var(--secondary-background);
}
5 changes: 0 additions & 5 deletions client/src/templates/Challenges/components/reset-modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,12 @@
.reset-modal-header {
color: var(--danger-color);
background-color: var(--danger-background);
border: none;
}

.reset-modal-header h4 {
color: var(--danger-color);
}

.reset-modal .modal-footer {
border-color: var(--danger-color);
}

.reset-modal-header .close {
color: var(--danger-color);
font-size: 28px;
Expand Down