fix(curriculum): changed challenge test text to use the word should for Responsive Web Design

[RandellDawson]

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the master branch of freeCodeCamp.
• None of my changes are plagiarized from another source without proper attribution.
• All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
• My changes do not use shortened URLs or affiliate links.

This PR has been on my to-do list for a while. After we made the change to no longer user the assert message arguments anymore and only use the text to display to the console for failing tests, I noticed several inconsistencies in how the text messages were written. Most use a should or should not, but others did not and some made it confusing to the camper whether or not they had passed or failed based on descriptions like: "Your code has an h1 element", when it really should have stated "Your code should have an h1 element.

When I queried the existing English challenges I found 763 text strings in 319 challenges that were not using the should or should not verbiage. Currently, I have only fixed 62 text strings in 27 challenges. Before I spend any more time on this, I want to first make sure this is a worthy cause. I personally believe it makes reading through all the challenges more consistent which should allow users to quickly understand what the test expects.

EDIT: This PR only deals with the Responsive Web Design section. Other PRs will fix the other sections.

[gitpod-io]

[ojeytonwilliams]

Messages like "Your code has an h1 element" are clearly awful, since they imply the opposite of what is actually required. I'm absolutely in favour of changing those.

Going from "Make sure your CSS rule is properly formatted with both opening and closing curly brackets" to "Your CSS rule should be properly formatted with both opening and closing curly brackets" seems, to me, to be a less critical change. Both convey what actions need to be taken. To be clear: I think it's an improvement, but I'd accept both versions.

So, my opinion is that changing the first type is definitely a worthy cause and changing the second type is still worth doing, but of lower priority.

[moT01]

Yea, I like them better how you suggested @RandellDawson - making them consistent throughout all of the challenges and more understandable would speed things up for users I think - I do recall having to read some of the test text a couple times when I was going through some of the lessons to figure it out. And it sounds like it's something you want to do, so I would say go for it.

[thecodingaviator]

I agree with what Oliver has to say

[RandellDawson]

@ojeytonwilliams , @moT01, @thecodingaviator This PR is ready for review. Because there are so many challenge files which will ultimately need to be reviewed, this PR is only for the Responsive Web Design section. I will create separate PRs for the other sections over the next few days.

[moT01]

Found a few typos and things that didn't make sense. Other than that, LGTM

[RandellDawson]

@moT01 Thanks for the review. Sorry about the typos and strange wording I used on some of them. I have committed all of your suggestions.

[moT01]

🎉 LGTM 🎉

[RandellDawson]

@thecodingaviator I committed your suggested change.

[thecodingaviator]

LGTM

[thecodingaviator]

@RandellDawson do you want to wait for Kris' and Oliver's reviews too?

[RandellDawson]

@thecodingaviator I think two reviewers is enough. I tagged the others just to get attention to the PR.

[thecodingaviator]

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

[ojeytonwilliams]

Sorry for being late to this. I went through it anyway, but couldn't find any problems. Looks great!