Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Arabic translation #36960

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Improve Arabic translation #36960

merged 1 commit into from
Jan 21, 2020

Conversation

kalmufti
Copy link
Contributor

@kalmufti kalmufti commented Oct 2, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

In all honesty the entire Arabic sections require a re-write. Direct translation from English to Arabic sounds awkward to us native Arabic speakers. Not sure how the devs would feel about that, as we'll need to understand the main idea of each section and re-write it in Arabic wording. Never the less, that's for the amazing work.
@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2019

@huyenltnguyen huyenltnguyen added language: Arabic scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Oct 2, 2019
@raisedadead
Copy link
Member

raisedadead commented Dec 23, 2019

Hi @kalmufti thanks for your pull request, can you get someone who speaks the language to do a peer review of the PR? You can also request them to take a look at all of your other PRs if any. Thanks.

@RandellDawson
Copy link
Member

RandellDawson commented Dec 23, 2019

Adding to what @raisedadead said, these are all 6 of the Arabic PRs that need to be reviewed for complete and correct translation of their English versions.

@ahmaxed ahmaxed merged commit 46e2a1b into freeCodeCamp:master Jan 21, 2020
@ahmaxed
Copy link
Member

ahmaxed commented Jan 21, 2020

Thanks for improving the Arabic translation @kalmufti.

abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants