Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: recursion test #37419

Merged
merged 2 commits into from Oct 22, 2019
Merged

Fix: recursion test #37419

merged 2 commits into from Oct 22, 2019

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Oct 20, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #37408

@gitpod-io
Copy link

gitpod-io bot commented Oct 20, 2019

@thecodingaviator thecodingaviator added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Oct 20, 2019
@moT01 moT01 changed the title Fix/recursion test Fix: recursion test Oct 21, 2019
@moT01 moT01 mentioned this pull request Oct 21, 2019
Merged
6 tasks
ojeytonwilliams
ojeytonwilliams approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raisedadead raisedadead merged commit 69d4d4f into freeCodeCamp:master Oct 22, 2019
@moT01 moT01 deleted the fix/recursion-test branch October 22, 2019 21:17
kishore-devaraj pushed a commit to kishore-devaraj/freeCodeCamp that referenced this pull request Oct 23, 2019
@moT01 @kishore-devaraj
fix: recursion test (freeCodeCamp#37419)
4427735 
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic JavaScript: Replace Loops using Recursion
4 participants
@moT01 @ojeytonwilliams @raisedadead @thecodingaviator