New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): enzyme => react-testing-library #37712
Conversation
Ah.. my bad. I forgot to mention and clarify that we use Enzyme for our in browser test runner (for the curriculum), where should probably leave it as is in the test runner(for now). Hey @ValeraS do you think there is a better way to test the react challenges? |
@raisedadead It may be difficult to replace the IMHO, we can use the |
Well, I added back |
Thanks @ValeraS ! |
@raisedadead I believe this PR may have broken something. We are receiving many reports on the forum about the React challenges no longer working. I have validated they do not seem to work on Chrome or Firefox. The following error appears in the console with the correct solution for the first challenge. |
Update: Now I am not sure. Reverting or not reverting the changes, I can not reproduce the problem locally. |
I can't reproduce it either. .org .dev and local all seem fine. Also, the changes in One complete guess is that, somehow, they've got a broken version of the enzyme adapter cached. Maybe. |
When you say "they", how do you mean? |
I just meant "the people that are experiencing the problem.". Since you don't see the problem when you |
Hi @RandellDawson @ojeytonwilliams can you point me to the threads on forum? Thanks. |
@raisedadead I have tried everything I know to do, but still get the error I show above when running any of the React challenges' tests. |
* refactor: 💡 rewrite enzyme tests in react-testing-library * fix: 🐛 remove enzyme imports from frame-runner.js * chore: 🤖 install and add enzyme imports to frame-runner.js back
Update index.md
)master
branch of freeCodeCamp.Closes #37690