Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update trivial regex capture group find and replace challenge #37768

Merged
merged 8 commits into from
Dec 14, 2019
Merged

refactor: update trivial regex capture group find and replace challenge #37768

merged 8 commits into from
Dec 14, 2019

Commits on Dec 4, 2019

  1. refactor: replace trivial regex capture group challenge 

    Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.

resolves #17645
    @PartyLich
    PartyLich committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    13e28e5 View commit details
    Browse the repository at this point in the history

  2. test: validate at least 3 capture groups were used 

    Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
    @PartyLich @RandellDawson
    PartyLich and RandellDawson committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c41877c View commit details
    Browse the repository at this point in the history

  3. refactor: more meaningful variable name 

    Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
    @PartyLich @RandellDawson
    PartyLich and RandellDawson committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    39fcaac View commit details
    Browse the repository at this point in the history

  4. test: add parenthesized substring test

    @PartyLich
    PartyLich committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c67fbb8 View commit details
    Browse the repository at this point in the history

  5. test: ensure 3 uses of substring replacement

    @PartyLich
    PartyLich committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    5f0a6ef View commit details
    Browse the repository at this point in the history

  6. refactor: reword instructions

    @PartyLich
    PartyLich committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    a122e00 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. fix: minor grammar fix 

    Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
    @PartyLich @Manish-Giri
    PartyLich and Manish-Giri committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    f65e5d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. refactor: elaborate wording in test

    @PartyLich
    PartyLich committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    3e9e46c View commit details
    Browse the repository at this point in the history