-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move time text out of icon element on map page #3779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noinkling
force-pushed
the
fix/map-clock-text
branch
from
October 17, 2015 05:37
9203a39
to
dfafb1e
Compare
noinkling
force-pushed
the
fix/map-clock-text
branch
from
October 17, 2015 05:41
dfafb1e
to
b1a5f51
Compare
Thank you, this looks great! :) |
ahstro
pushed a commit
that referenced
this pull request
Oct 18, 2015
Move time text out of icon element on map page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text next to the little clock icons ("3h" etc.) should not be inside the
<i>
element itself on which the icon classes are applied. FontAwesome is not designed to be used like this, so currently the FontAwesome font gets applied to the text as well, giving it a serif typeface that looks out of place.