docs: minor update to "set up fcc locally guidelines" - adding 'closing quotes' to docker set up #38149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hash2C
commented
Feb 1, 2020
Comment on lines
+294
to
+297
| | `npm run docker:test -- -c "npm run test"` | Run all JS tests in the system, including client, server, lint and challenge tests. | | ||
| | `npm run docker:test -- -c "npm run test:curriculum"` | Run the curriculum test suite. | | ||
| | `npm run docker:test -- -c "npm run test:client"` | Run the client test suite. | | ||
| | `npm run docker:test -- -c "npm run test:server"` | Run the server test suite. | |
There was a problem hiding this comment.
Just exploring. Gourgeous stuff xD
There was a problem hiding this comment.
Just exploring. Gourgeous stuff xD
Thank you for your cleanup
There was a problem hiding this comment.
it surely is a pleasure to contribute
|
@Hash2C Congrats on your first pull request (PR)! 🎉 Thank you for your contribution to the page! 👍 |
|
🎉🎉🎉 |
abbathaw
pushed a commit
to abbathaw/freeCodeCamp
that referenced
this pull request
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index.md)masterbranch of freeCodeCamp.On "how-to-setup-freecodecamp-locally.md".
Minor fix, helps new contributors to copy/paste the commands.
Just added some closing
"that were missing.Depending on the Docker configuration, it might be needed to prepend the commands with
sudo, I wonder if some "tip" should be included for this case.Going for the first freeCodeCamp pull request. Also looking for feedback. woohoo!