Disambiguate "Priority Queue" instructions

[TyMick]

Checklist:

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the master branch of freeCodeCamp.
• All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

For future reference, should I have combined #38803, #38804, and this one into a single PR?

[gitpod-io]

[moT01]

I have blocked this for now. See the pinned code freeze issue

[raisedadead]

Limitations removed on Coding Interview Prep Challenges.

[ojeytonwilliams]

For future reference, should I have combined #38803, #38804, and this one into a single PR?

There's no hard and fast rule for PRs, but each commit should be 'atomic' in the sense that it should be reasonably small and easy to understand. In this case it seems better to have those separate, because one changes style, the other meaning. It would be easy to miss the typo fix in the middle of all the changes to indentation.

As for this PR, I see that there's a reference to front (i.e. peek, I assume), but that does not appear in the tests or solution. Could you remove references to it or add a test? Either is fine.

[tinktink1]

I think that the changed you made to the instructions clears up everything. It could have been confusing for people just learning and I think that this will help them out good job!

[TyMick]

@ojeytonwilliams Added front() to the solution and a couple of tests along with it! Here's the prettified version of the second new test:

assert(
  (function () {
    var test = new PriorityQueue();
    test.enqueue(["David Brown", 2]);
    var front1 = text.front();
    test.enqueue(["Jon Snow", 1]);
    var front2 = test.front();
    test.dequeue();
    test.enqueue(["A", 3]);
    var front3 = test.front();
    test.enqueue(["B", 3]);
    test.enqueue(["C", 3]);
    test.dequeue();
    var front4 = test.front();
    return (
      front1 === "David Brown" &&
      front2 === "Jon Snow" &&
      front3 === "David Brown" &&
      front4 === "A"
    );
  })()
);

[gitpod-io]

[RandellDawson]

@tywmick One of your test's testStrings had a typo which caused the test to fail. Please correct and test your code locally by changing to the curriculum directory and running the following command:

npm run test -- -g "Create a Priority Queue Class"

Once you have passed all the tests successfully, you can make a new commit with the fixed code.

Thank you.

[TyMick]

Whoops, thanks for catching that, @RandellDawson! Tests passing now 👌🏼 Thanks for your help!

[RandellDawson]

LGTM @moT01 @ojeytonwilliams Merge if you agree.

[moT01]

LGTM @tywmick 🎉 Thanks for contributing to freeCodeCamp 🎉

I have added this solution to the guide as well 😄