Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(learn): remove cta and add current challenge button #38807
fix(learn): remove cta and add current challenge button #38807
Changes from 2 commits
11aa8ea
fb5a857
724318c
ec522f3
fc6dacc
f069b14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic wants to be
we could use https://github.com/freeCodeCamp/freeCodeCamp/blob/master/client/src/components/helpers/CurrentChallengeLink.js, with some style tweaks, to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the issue #38781 @ahmadabdolsaheb stated this.
He wanted these two as a separate feature if I am not misunderstanding....😅
He said that-
So, should I update the PR or is this enough @ojeytonwilliams ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed that discussion. It looks to me like the final decision hasn't been made yet. Given that, please don't implement what I've suggested until that decision's been clarified, as it may not be what's wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic states that:
For a signed in user:
The start here action should be when a user has less completed challenges than a certain threshold no. of challenges.
There should be a go to a current challenge action (a button in the stack is a good idea)
a. Should be shown only on signed in
b. Only when a user has completed at-least one challenge.
The sign in button is obviously not there in this case.
For a non-signed in user:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stack currently being "View my Portfolio", "Update my account settings"?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for clarifying guys! Much appreciated!