Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(learn): clarify formatting requirements for multiple ternary operators challenge #38993

Merged
merged 5 commits into from Jun 3, 2020

Conversation

jasnkwcz
Copy link
Contributor

@jasnkwcz jasnkwcz commented Jun 2, 2020

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38872

This change aims to condense the wording of the challenge requirements while also clarifying the formatting requirements necessary to pass the challenge.

@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2020

Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another contributor might pipe in about this change, but, for clarity, I would wrap the expected output in code tags.

…a-structures/basic-javascript/use-multiple-conditional-ternary-operators.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 95371f9 into freeCodeCamp:master Jun 3, 2020
@ojeytonwilliams
Copy link
Contributor

@jasnkwcz Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

@ojeytonwilliams
Copy link
Contributor

By the way, @jasnkwcz, if you want to keep working locally, you should pull down a fresh copy of master (since yours will now be out of sync). To avoid this, it's best to create new a new branch for new features.

If you have any difficulty, just ask here or in the contributors channel.

@jasnkwcz
Copy link
Contributor Author

jasnkwcz commented Jun 4, 2020

@ojeytonwilliams Thanks for the advice! I want to keep contributing - I've got the bug now. Very excited about my first PR.

abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
…ators challenge (freeCodeCamp#38993)

* fix(learn): clarify formatting requirements for multiple ternary operators challenge

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Challenge: Use Multiple Conditional (Ternary) Operators.
3 participants