Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Portuguese testStrings translated #39201

Merged
merged 2 commits into from Sep 29, 2020

Conversation

PeterF521
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

I did some translations on testStrings and I updated slice and splice description.

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2020

@moT01 moT01 added language: Portuguese scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jul 8, 2020
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a slight typo.

Additionally, can you explain the decision to change the challenge description? It appears your translation deviates from the English version.

@RandellDawson
Copy link
Member

RandellDawson commented Aug 4, 2020

FYI - Only a test's text will be displayed to a user. The assert message argument is ignored, so translating it is not necessary. Just make sure the localeTitle, description, instructions, and each test's text is the correct translation of the current English version on the master branch.

…data-structures/basic-algorithm-scripting/slice-and-splice.portuguese.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
RandellDawson
RandellDawson previously approved these changes Aug 31, 2020
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandellDawson RandellDawson dismissed their stale review August 31, 2020 23:38

Did not mean to approve.

@RandellDawson
Copy link
Member

@nhcarrigan Are the changes in this PR not warranted? If the challenge description is not the same as the English, then I think we can close this PR. Just let me know.

@naomi-lgbt
Copy link
Member

Heya @RandellDawson,

In full disclosure, I studied Spanish - lexically very similar to Portuguese, but there may be some idiomatic differences.

The current English text is:

You are given two arrays and an index. Copy each element of the first array into the second array, in order. Begin inserting elements at index n of the second array. Return the resulting array. The input arrays should remain the same after the function runs.

The original translation is roughly:

You are given two arrays and an index. Use the slice and splice array methods to copy each element from the first array to the second array, in order. Start by inserting elements into the nth index of the second array. Return the resulting array. The input arrays must remain the same after the function is executed. Remember to use Read- Search-Ask if you get stuck. Write your own code.

The proposed new translation is roughly:

Copy each element from the first array to the second array, in order. Start by inserting elements into the nth index of the second array. Return the resulting array. The input arrays must remain the same after the function is executed. Remember to use the Read-Search-Ask if you get stuck. Write your own code.

I'm not sure if the English text was updated since I last looked at this - but it seems the new translation is closer to the English text than the original translation, now. Neither are exact matches, however.

@RandellDawson
Copy link
Member

@PeterF521 Can you please take a look at the latest English version of this challenge and update this PR to better match the English version?

https://github.com/freeCodeCamp/freeCodeCamp/blob/master/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/slice-and-splice.english.md

Thanks in advance.

@PeterF521
Copy link
Contributor Author

Ok, I'll do it

@raisedadead raisedadead changed the title challenges: new slice and splice description and testStrings translated fix(i18n): Portuguese testStrings translated Sep 29, 2020
@raisedadead raisedadead merged commit ad9c3b0 into freeCodeCamp:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants