New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): Portuguese testStrings translated #39201
fix(i18n): Portuguese testStrings translated #39201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a slight typo.
Additionally, can you explain the decision to change the challenge description? It appears your translation deviates from the English version.
...ript-algorithms-and-data-structures/basic-algorithm-scripting/slice-and-splice.portuguese.md
Outdated
Show resolved
Hide resolved
FYI - Only a test's |
…data-structures/basic-algorithm-scripting/slice-and-splice.portuguese.md Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nhcarrigan Are the changes in this PR not warranted? If the challenge description is not the same as the English, then I think we can close this PR. Just let me know. |
Heya @RandellDawson, In full disclosure, I studied Spanish - lexically very similar to Portuguese, but there may be some idiomatic differences. The current English text is:
The original translation is roughly:
The proposed new translation is roughly:
I'm not sure if the English text was updated since I last looked at this - but it seems the new translation is closer to the English text than the original translation, now. Neither are exact matches, however. |
@PeterF521 Can you please take a look at the latest English version of this challenge and update this PR to better match the English version? Thanks in advance. |
Ok, I'll do it |
Checklist:
Update index.md
)master
branch of freeCodeCamp.I did some translations on testStrings and I updated slice and splice description.