Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust donation confirmation text #41140

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Adjust donation confirmation text #41140

merged 1 commit into from
Feb 16, 2021

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Feb 16, 2021 •
edited

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team February 16, 2021 20:31
@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2021 •
edited

@ahmaxed ahmaxed force-pushed the fix/adjust-donation-conformation branch from 833f7a0 to c0edcdb Compare February 16, 2021 20:33
naomi-lgbt
naomi-lgbt approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested locally:

image

RandellDawson
RandellDawson approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in Spanish too.

image

@ahmaxed ahmaxed merged commit 05a97d1 into freeCodeCamp:main Feb 16, 2021
@ojeytonwilliams ojeytonwilliams mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmaxed @RandellDawson @naomi-lgbt