New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge #41456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. (kidding just testing out the auto merge, randy is awesome)
@moT01 can you approve this change. I believe the merge should be held in place due to my change request review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Bazinga! That works |
@RandellDawson go ahead and dismiss my review. It should merge the PR. |
@raisedadead Cool, so not until you either dismiss your requested change or approve it, will anything else happen? |
That is correct. Why don't you go ahead and try dismissing my review? |
Testing dismissal of test review
Woah that's neat. |
I just hope this does not get abused. For instance, if there was a hold out mod that was requesting changes and two other mods approve and just decide to dismiss the other mod's requested changes. It could be a non-issue. |
I do not see myself making all that much use of this auto-merge feature, because I often edit the commit message. |
@ShaunSHamilton for what it is worth, the default commit message would be the title of the pull request. |
You will be able to edit the message prior commit. Everything works as usual (the only advantage is you skip the wait for a CI to pass, which could be helpful if we mandated the Cypress tests to be required) Screenshot of editing commit message prior enabling auto merge: |
Checklist:
Update index.md
)main
branch of freeCodeCamp.I created this PR to address a recurring confusion I see in the Nest an Anchor Element within a Paragraph challenge. This is the first challenge where the user is introduced to the concept of nesting an existing element into a newly created element. So many times, a user ends up creating another anchor element instead of just using the existing anchor element. Creating a new anchor element without the exact attributes/text of the original can lead to problems such as the one in this forum topic.
This PR aims to better guide the user into writing the correct code. This is similar to the approach we are taking in the v7 curriculum.