Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename APIs and Microservices to include "Backend" #42515

Merged
merged 21 commits into from
Jun 21, 2021
Merged

chore: rename APIs and Microservices to include "Backend" #42515

merged 21 commits into from
Jun 21, 2021

Conversation

heysujal
Copy link
Contributor

@heysujal heysujal commented Jun 15, 2021 •
edited by ShaunSHamilton
Loading

I have renamed "APIs and Microservices" to "Back End Development and APIs" and "Back End Development and APIs Certification" accordingly.

Related #42444

@heysujal heysujal requested review from a team as code owners June 15, 2021 19:01
@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2021

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Jun 15, 2021
raisedadead
raisedadead requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @heysujal

Thanks for the PR.

We recommend reading & following the contributing guide.

The pull-request template presented to you when opening a PR is there for a reason and we insist you follow it :)

For instance, the main branch of your fork will be soiled if and when we land this. While you can fix it up, it's non-trivial and will be a bit frustrating. We cover all of these pitfalls in our contributing guide.

Finally as for the PR. The changes seem good, please ensure the tests are passing.

Thanks again.

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Jun 16, 2021
raisedadead
raisedadead previously approved these changes Jun 16, 2021
View reviewed changes
@heysujal
Copy link
Contributor Author

Hi @heysujal

Thanks for the PR.

We recommend reading & following the contributing guide.

The pull-request template presented to you when opening a PR is there for a reason and we insist you follow it :)

For instance, the main branch of your fork will be soiled if and when we land this. While you can fix it up, it's non-trivial and will be a bit frustrating. We cover all of these pitfalls in our contributing guide.

Finally as for the PR. The changes seem good, please ensure the tests are passing.

Thanks again.

I will keep this in mind from now on. Thanks

@raisedadead raisedadead enabled auto-merge (squash) June 16, 2021 10:12
@raisedadead raisedadead changed the title Renamed APIs and Microservices to include "Backend" chore: rename APIs and Microservices to include "Backend" Jun 16, 2021
@raisedadead raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 16, 2021
@ShaunSHamilton ShaunSHamilton self-assigned this Jun 17, 2021
@raisedadead raisedadead changed the title chore: rename APIs and Microservices to include "Backend" chore: rename APIs and Microservices to include "Backend" Jun 18, 2021
@raisedadead raisedadead marked this pull request as draft June 18, 2021 13:31
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 18, 2021
@ShaunSHamilton
Copy link
Member

ShaunSHamilton commented Jun 18, 2021 •
edited
Loading

With this current change, old challenge links will 404:

- /learn/apis-and-microservices/apis-and-microservices-projects/file-metadata-microservice
+ /learn/back-end-development-and-apis/back-end-development-and-apis-projects/file-metadata-microservice

Mrugesh mentioned the possibility to re-route: https://github.com/freeCodeCamp/client-config/blob/master/serve.json

However, this change can be reverted. CC @ojeytonwilliams

Also, if this re-route is accepted, I will change the links in the READMEs throughout the codebase. By 'I', I mean create an issue, and get help

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 18, 2021
@ShaunSHamilton
Copy link
Member

Note to self: Naming should be Back-end Development and APIs with hyphen 🤦

@moT01
Copy link
Member

moT01 commented Jun 21, 2021

Should it? Front end doesn't include a hyphen.

@naomi-lgbt
Copy link
Member

Doesn't seem to be a real standard on this.

@ShaunSHamilton
Copy link
Member

Should it? Front end doesn't include a hyphen.

According to us, yes... https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges#:~:text=Front-end%20development

@naomi-lgbt
Copy link
Member

Should it? Front end doesn't include a hyphen.

According to us, yes... https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges#:~:text=Front-end%20development

I've spent enough time working on the docs that I should know this....

@ShaunSHamilton ShaunSHamilton changed the base branch from main to wip/certification-rename June 21, 2021 18:49
@ShaunSHamilton ShaunSHamilton marked this pull request as ready for review June 21, 2021 19:00
@ShaunSHamilton ShaunSHamilton merged commit a0f005c into freeCodeCamp:wip/certification-rename Jun 21, 2021
@ShaunSHamilton
Copy link
Member

@heysujal Thank you, for taking the time to contribute on this.

I have just merged this PR into a work-in-progress branch on freeCodeCamp, where changes can be made without affecting your fork.

@ShaunSHamilton ShaunSHamilton mentioned this pull request Jun 22, 2021
Merged
4 tasks
ojeytonwilliams pushed a commit that referenced this pull request Jul 9, 2021
@heysujal @ShaunSHamilton @ojeytonwilliams
chore: rename APIs and Microservices to include "Backend" (#42515)
80e2df6 
* fix typo

* fix typo

* undo change

* Corrected grammar mistake

Corrected a grammar mistake by removing a comma.

* change APIs and Microservices cert title

* update title

* Change APIs and Microservices certi title

* Update translations.json

* update title

* feat(curriculum): rename apis and microservices cert

* rename folder structure

* rename certificate

* rename learn Markdown

* apis-and-microservices -> back-end-development-and-apis

* update backend meta

* update i18n langs and cypress test

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
moT01 pushed a commit that referenced this pull request Aug 14, 2021
@ShaunSHamilton @heysujal
@NoorFakhry @ojeytonwilliams
feat: add 'back/front end' in curriculum (#42596)
c2a11ad 
* chore: rename APIs and Microservices to include "Backend" (#42515)

* fix typo

* fix typo

* undo change

* Corrected grammar mistake

Corrected a grammar mistake by removing a comma.

* change APIs and Microservices cert title

* update title

* Change APIs and Microservices certi title

* Update translations.json

* update title

* feat(curriculum): rename apis and microservices cert

* rename folder structure

* rename certificate

* rename learn Markdown

* apis-and-microservices -> back-end-development-and-apis

* update backend meta

* update i18n langs and cypress test

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: add development to front-end libraries (#42512)

* fix: added-the-word-Development-to-front-end-libraries

* fix/added-the-word-Development-to-front-end-libraries

* fix/added-word-development-to-front-end-libraries-in-other-related-files

* fix/added-the-word-Development-to-front-end-and-all-related-files

* fix/removed-typos-from-last-commit-in-index.md

* fix/reverted-changes-that-i-made-to-dependecies

* fix/removed xvfg

* fix/reverted changes that i made to package.json

* remove unwanted changes

* front-end-development-libraries changes

* rename backend certSlug and README

* update i18n folder names and keys

* test: add legacy path redirect tests

This uses serve.json from the client-config repo, since we currently use
that in production

* fix: create public dir before moving serve.json

* fix: add missing script

* refactor: collect redirect tests

* test: convert to cy.location for stricter tests

* rename certificate folder to 00-certificates

* change crowdin config to recognise new certificates location

* allow translations to be used

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add forwards slashes to path redirects

* fix cypress path tests again

* plese cypress

* fix: test different challenge

Okay so I literally have no idea why this one particular challenge
fails in Cypress Firefox ONLY. Tom and I paired and spun a full build
instance and confirmed in Firefox the page loads and redirects as
expected. Changing to another bootstrap challenge passes Cypress firefox
locally. Absolutely boggled by this.

AAAAAAAAAAAAAAA

* fix: separate the test

Okay apparently the test does not work unless we separate it into
a different `it` statement.

>:( >:( >:( >:(

Co-authored-by: Sujal Gupta <55016909+heysujal@users.noreply.github.com>
Co-authored-by: Noor Fakhry <65724923+NoorFakhry@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead left review comments

Assignees

@ShaunSHamilton ShaunSHamilton

Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename APIs and Microservices to include "Backend"
5 participants
@heysujal @ShaunSHamilton @moT01 @naomi-lgbt @raisedadead