Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw better error when JS parse fails #44032

Merged

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented Oct 27, 2021

This should help debugging challenges with invalid syntax.

Ref: #44031

This should help debugging challenges with invalid syntax.
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner October 27, 2021 14:09
@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2021

@ghost
Copy link

ghost commented Oct 27, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Should we add a test to go with this?

ojeytonwilliams and others added 2 commits October 27, 2021 16:32
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
@ojeytonwilliams
Copy link
Contributor Author

@ShaunSHamilton now we know the test works 💯

@raisedadead raisedadead enabled auto-merge (rebase) October 27, 2021 15:58
@raisedadead raisedadead merged commit e139fbc into freeCodeCamp:main Oct 27, 2021
@ojeytonwilliams ojeytonwilliams deleted the fix/improve-comment-parse-error branch October 27, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants