Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): colored markers - clarify meta tag description #47281

Merged
merged 2 commits into from Oct 11, 2022
Merged

fix(curriculum): colored markers - clarify meta tag description #47281

merged 2 commits into from Oct 11, 2022

Conversation

SoumyadebMisra
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #47266

Specified that a 'new' meta tag is to be added and added the reason for doing so.

@SoumyadebMisra
Update 616965351e74d4689eb6de30.md
9f12cc3 
fixes freeCodeCamp#47266

Specified that a new `meta` tag is to be added and added the reason for doing so.
@gitpod-io
Copy link

gitpod-io bot commented Aug 13, 2022

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Aug 13, 2022
@ghost
Copy link

ghost commented Aug 13, 2022 •
edited by ghost

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@ShaunSHamilton
Copy link
Member

Thank you for taking the time to contribute.

Please familiarise yourself with our Contributor Docs on how to open a PR. We accept PRs for issues with the help wanted or first timers only labels.

@ShaunSHamilton ShaunSHamilton added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Aug 13, 2022
@SoumyadebMisra
Copy link
Contributor Author

Thank you for taking the time to contribute.

Please familiarise yourself with our Contributor Docs on how to open a PR. We accept PRs for issues with the help wanted or first timers only labels.

Thank you. Will familarise myself with the contributor docs.

hanswang123456
hanswang123456 reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@hanswang123456 hanswang123456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual content looks good. Remember to follow PR titling guidelines.

@hanswang123456
Copy link
Contributor

image

@Sembauke Sembauke changed the title Update 2022/responsive-web-design/learn-css-colors-by-building-a-set-of-colored-markers/step-5 page to correctly specify what to do with <meta> tags fix(curriculum): clarify meta tag description on step 5 of building colored markers project Aug 25, 2022
Sembauke
Sembauke previously approved these changes Aug 25, 2022
View reviewed changes
@Sembauke Sembauke added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Aug 25, 2022
moT01
moT01 requested changes Aug 26, 2022
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep the instructions as short as possible. This sounds repetitive to me...

add a new <meta> tag with name attribute set to viewport
Nest a new self-closing meta element within the head. Give it a name attribute set to viewport

I don't think we need to mention the reason for needing a second tag. I would just go with something like this:

Finally, use a viewport <meta> tag to make sure your page looks the same on all devices.
Nest a second, self-closing, meta element within the head. Give it a name attribute set to viewport and a content attribute set to width=device-width, initial-scale=1.0.

My preference and opinion anyway.

@moT01 moT01 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Aug 26, 2022
@moT01 moT01 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Oct 3, 2022
@moT01
Copy link
Member

moT01 commented Oct 3, 2022

This has been sitting for a little while - I gave it an update to use my suggestion in the issue.

@raisedadead raisedadead requested review from Sembauke, moT01 and hanswang123456 and removed request for hanswang123456 October 10, 2022 21:01
@raisedadead raisedadead changed the title fix(curriculum): clarify meta tag description on step 5 of building colored markers project fix(curriculum): colored markers - clarify meta tag description Oct 10, 2022
@Sembauke Sembauke merged commit c8ca831 into freeCodeCamp:main Oct 11, 2022
shootermv pushed a commit to shootermv/freeCodeCamp that referenced this pull request Dec 20, 2022
@SoumyadebMisra @moT01 @shootermv
fix(curriculum): colored markers - clarify meta tag description (free…
9d5b999 
…CodeCamp#47281)

* Update 616965351e74d4689eb6de30.md

fixes freeCodeCamp#47266

Specified that a new `meta` tag is to be added and added the reason for doing so.

* fix: update wording

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanswang123456 hanswang123456 hanswang123456 left review comments

@moT01 moT01 moT01 approved these changes

@Sembauke Sembauke Sembauke approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Learn-css-colors-by-building-a-set-of-colored-markers - Step 5
5 participants
@SoumyadebMisra @ShaunSHamilton @hanswang123456 @moT01 @Sembauke