fix(learn): advanced-node-and-express username field

[Xavier-Pierre-dev]

Checklist:

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

I notice that for the moment the curriculum have a little coherency issue starting at github authentication. In reality at the start of the project we set up our strategy with the username property for example when we register an user using the form the curriculum will push us to use :

app.route('/register')
  .post((req, res, next) => {
    myDataBase.findOne({ username: req.body.username }, function(err, user) {
      if (err) {
        next(err);
      } else if (user) {
        res.redirect('/');
      } else {
        myDataBase.insertOne({
          username: req.body.username,
          password: req.body.password
        },
          (err, doc) => {
            if (err) {
              res.redirect('/');
            } else {
              // The inserted document is held within
              // the ops property of the doc
              next(null, doc.ops[0]);
            }
          }
        )
      }
    })
  },
    passport.authenticate('local', { failureRedirect: '/' }),
    (req, res, next) => {
      res.redirect('/profile');
    }
  );

As you can see we use username: req.body.username then we also use that to display content on profile.pug. In reality username property are use since start until the github authentication. In fact for github authentication username property are not set up so later with socket we use name instead of username this lead to an issue where if we login with something else than github the name will be undefined for the chat app and not be displayed.

This is why I propose some change inside the curriculum in order to add the username property when a user use github in order to register himself and edit the next step so the challenge guideline will push the learner to use the username instead of the user. To make it properly work either it's with simple register form, login with or without github

[gitpod-io]

[ghost]

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Legend

[Xavier-Pierre-dev]

Sorry I make a mistake with that :
Xavier-Pierre-dev requested review from hanswang123456 and removed request for ShaunSHamilton 8 minutes ago

It wasn't intentional, I clicked by mistake, this is my first PR.

[hanswang123456]

Looks Good!

[hanswang123456]

@Xavier-Pierre-dev Please get @ShaunSHamilton, @Sboonny, or @moT01 to review as they are actual reviewers. I'm just looking out for any small fixes.

[hanswang123456]

Also check out issue #47109. Might be a nice issue for you to attempt.

[ShaunSHamilton]

Hello there,

I am requesting changes to this PR to block it for now, because this will require the relevant Gists to be updated as well - something a member of staff will have to do.

[raisedadead]

@ShaunSHamilton let's review this and do any additional tasks. This has been sitting here for a while.

[ShaunSHamilton]

To mention, this is related to: #39599

[ShaunSHamilton]

This is ready to go in. Once we are production ready, we need to have the Gists updated based off of mine here: https://gist.github.com/ShaunSHamilton

Also, the boilerplate needs updating: <insert_pr_once_made>

[moT01]

This all looks real good @Xavier-Pierre-dev 🎉

I went through the whole thing pretty thoroughly. The project is pretty awesome - I never actually went through it like that.

I made quite a few suggestions to try and improve the instructions. Some of them were typos or other grammar suggestions in your additions, but most were because I was having a hard time differentiating explanation from instructions of what I was supposed to do. So it's mostly an attempt to clarify to campers what they are actually supposed to do or add - which I think is overdue. Also, the instructions for creating an app on GH needed some updating. Many of these were pre-existing and possibly outside the scope of this PR, but I think we should add them here. Let me know if you have any questions on any of it.

[scissorsneedfoodtoo]

I was only able to get through about half of the project, but everything is looking much better than before.

A lot of the things I noticed are pretty minor, so I'd be fine with disregarding a lot of them. Just wanted to point them out since there are a lot of other improvements here.

[moT01]

LGTM @ShaunSHamilton 🎉

[scissorsneedfoodtoo]

Thanks for all of your hard work on this @Xavier-Pierre-dev, and all the other improvements @ShaunSHamilton and @moT01 made look great. The instructions are much easier to follow now.

I went through the rest of the project and everything LGTM 👍

[naomi-lgbt]

Heya @moT01 is this still blocked? Or can we go ahead and get this in?

[raisedadead]

can we go ahead and get this in?

I believe as soon as the helper solutions are ready on the guide we are good to go.

[ShaunSHamilton]

Are we at the point I should add the solutions to this PR?

Approved by mistake 😓

[naomi-lgbt]

I think this is actually blocked until freeCodeCamp/boilerplate-advancednode#25 lands?

[moT01]

No, this needs to get in first, and once it hits production - we can merge that PR @naomi-lgbt.

[naomi-lgbt]

Okay, this looks good. The tests all pass with Shaun's solutions (and the updated boilerplate), and I don't see any issues with the copy.

[Xavier-Pierre-dev]

Sorry I wasn't able to see all of the avancement on this PR before today.

I also wanted to thanks @moT01, @ShaunSHamilton, @scissorsneedfoodtoo and all the contributors.