Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Learn Typography by building a Nutrition Label:Step 22 #47370

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

Xavier-Pierre-dev
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #47109

Change the test link to this hint :
Your span element should have the text 2/3 cup (55g).
so that one space is also allowed for the test

illustrategiftypoissue

So with this change the campers will not be block if he put one space or not.

@gitpod-io
Copy link

gitpod-io bot commented Aug 23, 2022

@camperbot
Copy link
Contributor

Thanks for your pull-request.

We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Aug 23, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Xavier-Pierre-dev Xavier-Pierre-dev changed the title fix/Learn Typography by building a Nutrition Label:Step 22 #47109 fix/Learn Typography by building a Nutrition Label:Step 22 Aug 23, 2022
@naomi-lgbt
Copy link
Member

Hey there @Xavier-Pierre-dev!

Thanks for your interest in contributing! As noted in the bot message, the non-English challenge files should not be modified through GitHub. These are managed by our translation workflows and will be synced in a separate PR.

Could you revert the changes to the non-English challenge files?

@Xavier-Pierre-dev
Copy link
Contributor Author

Hello @naomi-lgbt

Yes I will revert the change for the non-English files, sorry I wasn't aware about that.

@github-actions github-actions bot removed the scope: i18n language translation/internationalization. Often combined with language type label label Aug 23, 2022
…n-typography-by-building-a-nutrition-label/615f42a021625f656101ef93.md

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
@naomi-lgbt
Copy link
Member

Yes I will revert the change for the non-English files, sorry I wasn't aware about that.

No worries! That's why we have the bot. 💜

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Sembauke Sembauke enabled auto-merge (squash) August 24, 2022 09:18
@Sembauke Sembauke merged commit 0d40666 into freeCodeCamp:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn Typography by building a Nutrition Label:Step 22
4 participants