-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/Learn Typography by building a Nutrition Label:Step 22 #47370
fix/Learn Typography by building a Nutrition Label:Step 22 #47370
Conversation
Thanks for your pull-request. We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources. As always, we value all of your contributions. Happy contributing! Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat. |
👀 Review this PR in a CodeSee Review Map |
Hey there @Xavier-Pierre-dev! Thanks for your interest in contributing! As noted in the bot message, the non-English challenge files should not be modified through GitHub. These are managed by our translation workflows and will be synced in a separate PR. Could you revert the changes to the non-English challenge files? |
Hello @naomi-lgbt Yes I will revert the change for the non-English files, sorry I wasn't aware about that. |
...ive-web-design-22/learn-typography-by-building-a-nutrition-label/615f42a021625f656101ef93.md
Outdated
Show resolved
Hide resolved
…n-typography-by-building-a-nutrition-label/615f42a021625f656101ef93.md Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
No worries! That's why we have the bot. 💜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Checklist:
Update index.md
)main
branch of freeCodeCamp.Closes #47109
Change the test link to this hint :
Your
span
element should have the text2/3 cup (55g)
.so that one space is also allowed for the test
So with this change the campers will not be block if he put one space or not.