refactor(api): add wrapper around prisma calls #50696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a fairly leaky abstraction, but it cleans up the handlers so might be worth it.
github-actions
bot
added
the
platform: api
|
👀 Review this PR in a CodeSee Review Map View the CodeSee Map of this changeLegend
|
|
Sorry, I shouldn't have left this as a draft. Thanks to Sem for the reminder. Anyways: while it seems a bit weird to add another layer of abstraction over the thing that abstracts over the database, I quite like how clean the functions are. Any thoughts? |
|
There's no rush on this one. I think it's worth considering post MVP, but not before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a fairly leaky abstraction, but it cleans up the handlers so might be worth it.
Checklist:
mainbranch of freeCodeCamp.