Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

est(e2e,playwright): 404 Page #51777

Closed
wants to merge 2 commits into from
Closed

est(e2e,playwright): 404 Page #51777

wants to merge 2 commits into from

Conversation

VaibhavAPatil
Copy link

Checklist:

Closes #51705

@VaibhavAPatil VaibhavAPatil requested a review from a team as a code owner October 3, 2023 10:36
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@naomi-lgbt
Copy link
Member

Hello,

Firstly, thank you for submitting this pull request!

As you navigate through the process, we have a PR checklist to ensure consistency and quality in our contributions. We kindly ask that you genuinely follow through with each point. This not only facilitates the review process but also demonstrates a mutual respect for the community's efforts.

If you're unfamiliar with certain aspects, our contributing guidelines are a helpful resource to get you up to speed.

**Friendly Pointers (click to expand)**
  1. Editing on GitHub: While it's possible to edit files directly on GitHub, it's typically better not to. This helps avoid inadvertent mistakes like typos that can disrupt tests.

  2. Linking Issues: Please ensure you link issues using the designated method. Simply update the XXXXXX in the PR description to include the issue number. This keeps our records organized and clear.

  3. Engaging with the Team: We know you're eager, but kindly keep mentions and review requests limited. Our maintainers are always on the lookout and will attend to PRs in the order they come in.

  4. Branch Management: It's a good practice not to work directly off your main branch. Creating separate branches for different changes allows you to smoothly update your PR even as the main repository progresses.

Please note, there's no need to close this PR. If you have questions or need guidance refining your contribution, don't hesitate to ask. Our community is here to assist.

Thank you for your enthusiasm in contributing to our project. We eagerly await more contributions from you!

Happy Contributing! 🌟

@naomi-lgbt naomi-lgbt added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Oct 3, 2023
@VaibhavAPatil VaibhavAPatil closed this by deleting the head repository Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Migrate Cypress to Playwright
2 participants