fix(ui): display checkmark on completed C# challenges #52504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: learn
|
👀 Review this PR in a CodeSee Review Map View the CodeSee Map of this changeLegend
|
huyenltnguyen
force-pushed
the
fix/csharp-challenges-checkmark
branch
from
b9c95f7
to
83f5cdd
Compare
huyenltnguyen
commented
Dec 7, 2023
|
Hey @huyenltnguyen, this is looking good 👍 I was working on this one that does some similar things. I think we should be fine to get this in and I can fix up any conflicts on my PR if they arise. |
moT01
added
the
status: waiting review
4 tasks
moT01
approved these changes
Dec 15, 2023
|
I resolved the minor conflict on this cause it would be nice to get it in. |
naomi-lgbt
approved these changes
Dec 18, 2023
nieldakarla
pushed a commit
to nieldakarla/freeCodeCamp
that referenced
this pull request
Jan 19, 2024
…2504) Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.I found that completed C# challenges don't have a checkmark next to their title. I'm addressing this by replacing the
h2element with theChallengeTitlecomponent, which has the checkmark built-in.Side effects of this change are:
h1instead of anh2. This helps make the pages more accessible as C# challenge pages don't have anh1at the momentScreenshots