Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): allow spaces before the colon in step 9 of the music player project #52883

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(curriculum): allow spaces before the colon in step 9 of the music player project #52883

merged 1 commit into from
Jan 3, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Jan 2, 2024

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jan 2, 2024
@ghost
Copy link

ghost commented Jan 2, 2024

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 2, 2024
moT01
moT01 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@huyenltnguyen huyenltnguyen changed the title fix(cirriculum) - allow spaces before the colon in step 9 of the music player project fix(curriculum): allow spaces before the colon in step 9 of the music player project Jan 3, 2024
@huyenltnguyen huyenltnguyen merged commit 0d123e0 into freeCodeCamp:main Jan 3, 2024
25 checks passed
nieldakarla pushed a commit to nieldakarla/freeCodeCamp that referenced this pull request Jan 19, 2024
@a2937 @nieldakarla
fix(curriculum): allow spaces before the colon in step 9 of the music…
cad5bd5 
… player project (freeCodeCamp#52883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a2937 @moT01 @huyenltnguyen