Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): migrate buttons on the settings page to ui-components #53739

Merged
merged 3 commits into from
Mar 8, 2024
Merged

refactor(client): migrate buttons on the settings page to ui-components #53739

merged 3 commits into from
Mar 8, 2024

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented Feb 15, 2024 •
edited
Loading

Checklist:

This PR:

Note for reviewers: This PR contains 2 commits: a revert commit and a fix. You might only want to look at the latter: 8c109ea.

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024 •
edited by ghost
Loading

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@huyenltnguyen huyenltnguyen force-pushed the refactor/settings-buttons branch 6 times, most recently from 98e0f82 to f12aa3f Compare February 16, 2024 05:28
This was referenced Feb 16, 2024
Closed
Merged
@huyenltnguyen huyenltnguyen marked this pull request as ready for review February 22, 2024 06:29
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner February 22, 2024 06:29
@Sembauke Sembauke added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Feb 26, 2024
@huyenltnguyen huyenltnguyen mentioned this pull request Feb 26, 2024
Closed
@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Feb 26, 2024
@Sembauke Sembauke added status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Feb 27, 2024
ojeytonwilliams
ojeytonwilliams requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @huyenltnguyen! I only found a few things that were a little puzzling, but that might just be me 😰

client/src/components/settings/certification.tsx Outdated Show resolved Hide resolved
cypress/e2e/default/learn/challenges/projects.ts Show resolved Hide resolved
client/src/components/settings/__snapshots__/honesty.test.tsx.snap Show resolved Hide resolved
client/src/components/settings/toggle-button-setting.tsx Show resolved Hide resolved
@huyenltnguyen huyenltnguyen removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Mar 4, 2024
ojeytonwilliams
ojeytonwilliams approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @huyenltnguyen!

LGTM 👍

@ojeytonwilliams ojeytonwilliams added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 5, 2024
@ahmaxed ahmaxed requested a review from naomi-lgbt March 6, 2024 18:30
@Sembauke Sembauke merged commit 138a80f into freeCodeCamp:main Mar 8, 2024
22 checks passed
@huyenltnguyen huyenltnguyen deleted the refactor/settings-buttons branch March 12, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@Sembauke Sembauke Sembauke approved these changes

@naomi-lgbt naomi-lgbt Awaiting requested review from naomi-lgbt

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Button component off of Bootstrap
4 participants
@huyenltnguyen @ojeytonwilliams @Sembauke @naomi-lgbt