Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Added a note on how the players are numbered for team cards #54121

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix(curriculum): Added a note on how the players are numbered for team cards #54121

merged 4 commits into from
Mar 18, 2024

Conversation

haripajjuri
Copy link
Contributor

@haripajjuri haripajjuri commented Mar 17, 2024 •
edited
Loading

Checklist:

Closes #54118

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Mar 17, 2024
@haripajjuri haripajjuri changed the title #54118:Added a Note on How the Players are Numbered for team cards chore(learn): Added a note on how the players are numbered for team cards Mar 17, 2024
@haripajjuri haripajjuri changed the title chore(learn): Added a note on how the players are numbered for team cards chore: Added a note on how the players are numbered for team cards Mar 17, 2024
@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP new javascript course These are for issues dealing with the new JS curriculum labels Mar 18, 2024
@huyenltnguyen huyenltnguyen changed the title chore: Added a note on how the players are numbered for team cards fix(curriculum): Added a note on how the players are numbered for team cards Mar 18, 2024
haripajjuri and others added 3 commits March 18, 2024 10:03
@haripajjuri @huyenltnguyen
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
c98698d 
…a-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63c620161fc2b49ac340ffc4.md

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@haripajjuri @huyenltnguyen
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
776aa21 
…a-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63d1214a0ac7a9389793269b.md

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@haripajjuri @huyenltnguyen
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
ffb2e65 
…a-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63d1214a0ac7a9389793269b.md

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Mar 18, 2024
jdwilkin4
jdwilkin4 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit 5b2794b into freeCodeCamp:main Mar 18, 2024
22 checks passed
@haripajjuri
Copy link
Contributor Author

Thank you 🤖🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Note on How the Players are Numbered for team cards project
3 participants
@haripajjuri @huyenltnguyen @jdwilkin4