Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-components): modal body alignment #54161

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(ui-components): modal body alignment #54161

merged 1 commit into from
Mar 22, 2024

Conversation

huyenltnguyen
Copy link
Member

Checklist:

This PR adds alignment option to Modal.Body.

Screenshots
Alignment Screenshot
center Screenshot 2024-03-21 at 12 02 54
left Screenshot 2024-03-21 at 12 03 15
start Screenshot 2024-03-21 at 12 13 27

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Mar 21, 2024
@huyenltnguyen huyenltnguyen marked this pull request as ready for review March 21, 2024 05:51
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner March 21, 2024 05:51
@huyenltnguyen huyenltnguyen mentioned this pull request Mar 22, 2024
Merged
18 tasks
@ahmaxed ahmaxed merged commit 623d691 into freeCodeCamp:main Mar 22, 2024
23 checks passed
@huyenltnguyen huyenltnguyen deleted the fix/modal-body-alignment branch March 22, 2024 07:46
@ahmaxed
Copy link
Member

ahmaxed commented Mar 22, 2024

We might want to consider aligning the text independently from the modal.

I looked through other component libraries, but could not find a similar pattern. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmaxed ahmaxed ahmaxed approved these changes

@Sembauke Sembauke Sembauke approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huyenltnguyen @ahmaxed @Sembauke