Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added stats component to profile page #54301

Merged
merged 4 commits into from Apr 27, 2024

Conversation

jenna5376
Copy link
Contributor

Checklist:

Related to #48234

Added stats component to profile page, removed streaks from heat map

Screen Shot 2024-04-04 at 12 33 44 PM Screen Shot 2024-04-04 at 12 34 03 PM

@jenna5376 jenna5376 requested a review from a team as a code owner April 4, 2024 16:36
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Apr 4, 2024
@jenna5376
Copy link
Contributor Author

@ahmaxed would love some feedback on this!

@camperbot
Copy link
Contributor

We realize you're looking to get help as soon as possible. Rather than pinging someone directly, which can be considered rude, would you mind joining our Discord and asking your question there? Someone might be more readily available to help.

@camperbot
Copy link
Contributor

We would love to be able to merge your changes but it looks like there is an error with the CI build. ⚠️

Once you resolve these issues, we will be able to review your PR and merge it. 😊


Feel free to reference the contributing guidelines for instructions on running the CI build locally. ✅

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 9, 2024
@ahmaxed
Copy link
Member

ahmaxed commented Apr 15, 2024

Looks good. I wonder if we should start left aligning the titles.
Have a look at the failing tests, so I could go for a deep dive review.
Isolating the stats into its own component makes sense.

@jenna5376
Copy link
Contributor Author

Thank you so much for the feedback! I just addressed the failing tests.
I think we should left align the titles all at once in a separate pull request. What do you think?

@Sembauke Sembauke requested a review from bbsmooth April 18, 2024 09:05
@naomi-lgbt naomi-lgbt added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 25, 2024
@ahmaxed ahmaxed merged commit 5cbe0b7 into freeCodeCamp:main Apr 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants