refactor(curriculum): updating step 22 of stats calculator project

[jdwilkin4]

Summary of changes

This step comes up a lot on the forum. The issues seem to be the strictness of the tests and the understanding of the problem. The original step had a lot of the answer baked into the hints. But based on forum interaction, it looks like people are copying the answer from the hints without understanding what it means. So I moved the answers out of the hints and expanded the description instead. Also, I removed the separate step to return median and just moved that into step 22.
That way are tests just check for the correct return value without a regex test. This will allow for greater flexibility in correct answers from campers.

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

[jdwilkin4]

Not sure why the test for the Build new API container is failing 🤔

[Supravisor]

Hi @jdwilkin4 , may I work on this one? I had similar issues with CI - Node.js / Test italian and portuguese

[jdwilkin4]

@Supravisor

Any issues dealing with CI/CD stuff is handled by the dev team

[huyenltnguyen]

Not sure why the test for the Build new API container is failing

@jdwilkin4 I think it was a Jest hiccup (it sometimes fails to handle a large amount of tests at the same time). I reran the job and CI is green now.

[naomi-lgbt]

Sorry @jdwilkin4 I merged the step 27 PR and turned this into a mess.

[naomi-lgbt]

Pulled this one down. I'm not sure about these changes - I do worry that step 22 has now become a LOT to parse/understand at once.

[jdwilkin4]

@naomi-lgbt

There might be a way to experiment with breaking this up into multiple steps.

I would have to play around with it.
But if broken up differently it would help with the confusion on the forum
https://forum.freecodecamp.org/search?q=step%2022%20%23javascript%20Statistics

Also, we could still test the final result so it allows for more flexibility in answers like this one
https://forum.freecodecamp.org/t/learn-advanced-array-methods-by-building-a-statistics-calculator-step-22/670107/2

[naomi-lgbt]

Yes, I'd definitely love to address the consistent tripping points on the forum.

But I also struggled with the state of step 22 here, myself 😅

[jdwilkin4]

@naomi-lgbt

I broke up the step, into a few steps.

The first one focuses on how to check if array length is even or not.
The second one focuses on how to find the median for odd length list of numbers
The third one focuses on how to find the median for even length list of numbers
The fourth one asks them to remove the test code

Then the last one asks them to put all they learned together to check if array is even. If so return the median for that, otherwise return the median for odd list. This lets campers write whatever solution they want to.

I removed the requirement for create the median variable and ternary.
The way I see it, if/else should be a viable solution.
As long as they return the right info, then it should be good.

I tested it out with if/else solution, a ternary solution, the original solution, and a solution created different variables for middle numbers with an if/else. They are passing on my end

[Ksound22]

Well done, @jdwilkin4!

[Ksound22]

This has two approvals already. Why is not yet merged?

[jdwilkin4]

@Ksound22

This has two approvals already. Why is not yet merged?

When someone requests changes that need to be made, the person who requested them needs to approve those changes before it can be merged in. Otherwise, merging is blocked for the PR.

That is how the fcc repo is setup