feat(curriculum): add English curriculum block 8.3 expressing agreement or disagreement #54352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scope: curriculum
added 2 commits
April 25, 2024 13:48
naomi-lgbt
approved these changes
Apr 25, 2024
naomi-lgbt
added
the
status: waiting review
moT01
reviewed
May 1, 2024
There was a problem hiding this comment.
This looks good 🎉 I pushed a few minor grammar fixes.
A couple other concerns:
Task 16: the answers are in backticks and won’t be translated. It feels like they shouldn’t be in backticks, but I'm not sure.
Tasks 27, 28, and 31 have quotes in the backticks - e.g. `"I weakly believe in our team's weaknesses."` I'm not sure if we need the quotes. I would vote no.
moT01
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.