Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(curriculum): update RPG project to accommodate new intro pyramid project #54435

Merged
merged 2 commits into from
Apr 22, 2024
Merged

refactor(curriculum): update RPG project to accommodate new intro pyramid project #54435

merged 2 commits into from
Apr 22, 2024

Conversation

jdwilkin4
Copy link
Contributor

Checklist:

@jdwilkin4 jdwilkin4 added the new javascript course These are for issues dealing with the new JS curriculum label Apr 18, 2024
@jdwilkin4 jdwilkin4 self-assigned this Apr 18, 2024
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner April 18, 2024 03:52
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 18, 2024
Sembauke
Sembauke requested changes Apr 18, 2024
View reviewed changes
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/5d5a813321b9e3db6c106a46.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62a3b41c9494f937560640ab.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62a7cc99577fbf25ee7a7d76.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62a8ce73d0dce43468f6689c.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa264d23cdaa45a20efada.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa27c40ca6f04ab8be5fac.md Outdated Show resolved Hide resolved
...ctures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa27c40ca6f04ab8be5fac.md Outdated Show resolved Hide resolved
@jdwilkin4 @Sembauke
Apply suggestions from code review
18e9ae1 
Co-authored-by: Sem Bauke <semboot699@gmail.com>
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 18, 2024
@jdwilkin4 jdwilkin4 requested a review from Sembauke April 18, 2024 16:43
@Sembauke Sembauke enabled auto-merge (squash) April 18, 2024 16:44
@Sembauke Sembauke merged commit eed5575 into freeCodeCamp:main Apr 22, 2024
22 checks passed
ahmaxed pushed a commit to ahmaxed/freeCodeCamp that referenced this pull request Apr 25, 2024
@jdwilkin4 @Sembauke @ahmaxed
refactor(curriculum): update RPG project to accommodate new intro pyr…
3a8fb76 
…amid project (freeCodeCamp#54435)

Co-authored-by: Sem Bauke <semboot699@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sembauke Sembauke Sembauke approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@JoyShaheb JoyShaheb Awaiting requested review from JoyShaheb

@Ksound22 Ksound22 Awaiting requested review from Ksound22

Assignees

@jdwilkin4 jdwilkin4

Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdwilkin4 @Sembauke @naomi-lgbt