Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(learn) : update the quiz cert footer #54442

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Apr 18, 2024

Checklist:

Closes #54282

The wording for the description of the certification has been updated and the footer is now conditionally not present for the C# exam certification.

@a2937 a2937 requested a review from a team as a code owner April 18, 2024 14:34
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 18, 2024
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what a handing is, but probably not something either of us want.

client/src/client-only-routes/show-project-links.tsx Outdated Show resolved Hide resolved
client/src/client-only-routes/show-project-links.tsx Outdated Show resolved Hide resolved
@a2937
Copy link
Member Author

a2937 commented Apr 18, 2024

Typo has been fixed.

@a2937 a2937 requested a review from naomi-lgbt April 18, 2024 19:16
@Sembauke
Copy link
Member

Hey @a2937,

Thank you for making this pr. Some of the test are failing could you take a look?

If you need any help with resolving the test errors let me know!

@Sembauke Sembauke added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 19, 2024
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Apr 19, 2024
@a2937
Copy link
Member Author

a2937 commented Apr 22, 2024

image

I don't understand why the tests are failing on GitHub. While I did modify my local development user account to gain this certificate (plus did a quick change back and forth on the tests) nothing seemed broken. The only reason why the tests failed locally were because the issuing dates were different the seed data results.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had weirdness with toBeNull().

e2e/certification.spec.ts Outdated Show resolved Hide resolved
e2e/certification.spec.ts Outdated Show resolved Hide resolved
a2937 and others added 3 commits April 22, 2024 16:33
Co-authored-by: Naomi <nhcarrigan@gmail.com>
Co-authored-by: Naomi <nhcarrigan@gmail.com>
@a2937 a2937 requested a review from naomi-lgbt April 23, 2024 20:20
@naomi-lgbt naomi-lgbt added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 25, 2024
@jdwilkin4 jdwilkin4 merged commit 2a4c291 into freeCodeCamp:main Apr 25, 2024
22 checks passed
@a2937 a2937 deleted the fix(learn)/update-cert-footer branch April 25, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update certification footer for exam-based certifications
4 participants