Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: made timeAgo function way shorter and viewCount shorter #54583

Merged
merged 6 commits into from May 20, 2024
Merged

fix: made timeAgo function way shorter and viewCount shorter #54583

merged 6 commits into from May 20, 2024

Conversation

Ksound22
Copy link
Member

Checklist:

Closes #XXXXX

Check steps 22 and 23 for the timeAgo function, and step 25 for the viewCount function.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Apr 30, 2024
@Ksound22 Ksound22 requested review from jdwilkin4 and gikf April 30, 2024 11:27
jdwilkin4
jdwilkin4 reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things look good.
Left some comments 👍

...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md Show resolved Hide resolved
Ksound22 and others added 2 commits May 1, 2024 08:42
@Ksound22 @jdwilkin4
chore: Implemented a review suggestion from Jessica
2813ed6 
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@Ksound22
chore: implemented Jessica's review suggestions
49dd3d2
@Ksound22 Ksound22 requested a review from jdwilkin4 May 6, 2024 06:40
jdwilkin4
jdwilkin4 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through again and found a couple of small things.
but otherwise good

...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md Show resolved Hide resolved
@Ksound22 @jdwilkin4
chore: implemented more review suggestions from Jessica
8e59dd9 
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
jdwilkin4
jdwilkin4 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 7, 2024
moT01
moT01 requested changes May 16, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes in the meta.json file on this PR. I think the challengeOrder needs to be changed to match all these changes.

@moT01 moT01 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 16, 2024
@jdwilkin4
Copy link
Contributor

Good catch Tom!
I didn't catch that because I had copied the changes into my testing branch.

Maybe the pnpm run repair-meta will fix it @Ksound22 ?
https://contribute.freecodecamp.org/#/how-to-work-on-practice-projects?id=how-to-work-on-practice-projects

Usually though, when you run the pnpm run delete-step that should have updated the meta.json file.
Not sure why those changes were not showing up in the PR

JoyShaheb
JoyShaheb requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! just minor optional suggestions.

...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md Outdated Show resolved Hide resolved
@Ksound22 @JoyShaheb
chore: implemented Joy's review suggestions
6a99dcf 
Co-authored-by: Joy Shaheb <khondokoralam@gmail.com>
@Ksound22
Copy link
Member Author

Good catch Tom! I didn't catch that because I had copied the changes into my testing branch.

Maybe the pnpm run repair-meta will fix it @Ksound22 ? https://contribute.freecodecamp.org/#/how-to-work-on-practice-projects?id=how-to-work-on-practice-projects

Usually though, when you run the pnpm run delete-step that should have updated the meta.json file. Not sure why those changes were not showing up in the PR

Yea I expected the meta.json file to be automatically updated. I'm on it now.

@Ksound22 Ksound22 requested a review from a team as a code owner May 17, 2024 10:12
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label May 17, 2024
@Ksound22 Ksound22 requested review from JoyShaheb and moT01 May 17, 2024 21:00
@JoyShaheb JoyShaheb requested a review from jdwilkin4 May 18, 2024 16:15
@moT01 moT01 self-assigned this May 20, 2024
@moT01 moT01 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 20, 2024
@moT01 moT01 merged commit 32b93cf into freeCodeCamp:main May 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@JoyShaheb JoyShaheb JoyShaheb approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

@gikf gikf Awaiting requested review from gikf

@huyenltnguyen huyenltnguyen Awaiting requested review from huyenltnguyen

Assignees

@moT01 moT01

Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ksound22 @jdwilkin4 @moT01 @JoyShaheb