Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): allow positive numbers only for decimal to binary conversion #54708

Merged
merged 8 commits into from
May 22, 2024
Merged

fix(curriculum): allow positive numbers only for decimal to binary conversion #54708

merged 8 commits into from
May 22, 2024

Conversation

DeepaPrasanna
Copy link
Contributor

@DeepaPrasanna DeepaPrasanna commented May 8, 2024 •
edited

Checklist:

Closes #54651

  1. Added a note in Step 1 that conversion is for positive numbers only
    image

  2. Updated the if statement in required files
    image

image

  1. Updated the instructions in step 12
    image

  2. Updated the hint in step 12 when code does not pass
    image
    image

  3. Success message when the code successfully passes
    image

  4. Updated hint in step 78
    image

    on success,
    image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 8, 2024
@DeepaPrasanna DeepaPrasanna reopened this May 9, 2024
@jdwilkin4 jdwilkin4 added the new javascript course These are for issues dealing with the new JS curriculum label May 10, 2024
@Ksound22
Copy link
Member

This looks good. I'll approve when the conversation is resolved!

@DeepaPrasanna
Copy link
Contributor Author

This looks good. I'll approve when the conversation is resolved!

done!

@jdwilkin4 jdwilkin4 requested a review from Ksound22 May 13, 2024 20:39
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 13, 2024
@jdwilkin4 jdwilkin4 requested a review from JoyShaheb May 13, 2024 20:39
@jdwilkin4 jdwilkin4 requested a review from JoyShaheb May 20, 2024 15:24
@jdwilkin4 jdwilkin4 merged commit e70ef2a into freeCodeCamp:main May 22, 2024
22 checks passed
@jdwilkin4 jdwilkin4 mentioned this pull request May 22, 2024
Closed
4 tasks
@DeepaPrasanna DeepaPrasanna deleted the fix/decimal-to-binary-for-positive-numbers-only branch May 23, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyShaheb JoyShaheb JoyShaheb approved these changes

@Ksound22 Ksound22 Ksound22 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor decimal to binary converter to check for positive numbers only
4 participants
@DeepaPrasanna @Ksound22 @JoyShaheb @jdwilkin4