Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): test in password generator project, step 54 #54804

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(curriculum): test in password generator project, step 54 #54804

merged 2 commits into from
May 22, 2024

Conversation

Dario-DC
Copy link
Contributor

Checklist:

Related to #54647

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 15, 2024
@Dario-DC Dario-DC mentioned this pull request May 15, 2024
Closed
9 tasks
@Dario-DC Dario-DC added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 15, 2024
zairahira
zairahira reviewed May 17, 2024
View reviewed changes
Copy link
Member

@zairahira zairahira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is now checking for pass to resolve the console exception👍️
The suggested change in hint isn't compulsory.

...ython/learn-regular-expressions-by-building-a-password-generator/6564f834dd717998092cfd47.md Outdated Show resolved Hide resolved
@zairahira zairahira requested review from fhsinchy and a team May 17, 2024 11:56
ilenia-magoni
ilenia-magoni approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ilenia-magoni ilenia-magoni merged commit 5a44a9d into freeCodeCamp:main May 22, 2024
22 checks passed
@Dario-DC Dario-DC deleted the fix-test branch May 22, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilenia-magoni ilenia-magoni ilenia-magoni approved these changes

@zairahira zairahira zairahira approved these changes

@fhsinchy fhsinchy Awaiting requested review from fhsinchy

Assignees
No one assigned
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dario-DC @ilenia-magoni @zairahira