Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Created the new review steps 12 and 13 in pyramid project #54936

Merged
merged 12 commits into from
May 28, 2024
Merged

fix(curriculum): Created the new review steps 12 and 13 in pyramid project #54936

merged 12 commits into from
May 28, 2024

Conversation

cheenu-1824
Copy link
Contributor

Checklist:

Closes #54931

PR Description

This PR aims to solve the issue of campers having to review pyramid project for new concepts. Theses two new steps aim to reinforce the new knowledge gained in step 11 through using it again in a different context, helping them better grasp the new information. Here are the changes recommended to made implemented into the codebase.

Changes

New Step 12:
Screenshot 2024-05-23 at 4 13 50 pm
Screenshot 2024-05-23 at 4 14 07 pm
Screenshot 2024-05-23 at 4 14 55 pm

New Step 13:
Screenshot 2024-05-23 at 4 15 52 pm
Screenshot 2024-05-23 at 4 16 07 pm

I have tested that all hints appear properly locally on my machine.

@cheenu-1824 cheenu-1824 requested a review from a team as a code owner May 23, 2024 07:03
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 23, 2024
@cheenu-1824 cheenu-1824 changed the title Created the new review steps 12 and 13 in pyramid project fix(curriculum): Created the new review steps 12 and 13 in pyramid project May 23, 2024
@huyenltnguyen huyenltnguyen added the new javascript course These are for issues dealing with the new JS curriculum label May 24, 2024
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 24, 2024
naomi-lgbt
naomi-lgbt requested changes May 25, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the list in the description for step 12, either, but I need to stew on that a bit.

...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
cheenu-1824 and others added 4 commits May 26, 2024 14:53
@cheenu-1824 @naomi-lgbt
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
bb1a573 
…a-structures-22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md

Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@cheenu-1824 @naomi-lgbt
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
a115451 
…a-structures-22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md

Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@cheenu-1824 @naomi-lgbt
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
17039d4 
…a-structures-22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md

Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@cheenu-1824 @naomi-lgbt
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
bd17579 
…a-structures-22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md

Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@cheenu-1824
Copy link
Contributor Author

cheenu-1824 commented May 26, 2024 •
edited
Loading

Thanks for the feedback, I forgot that in console logs, people can format it differently with spaces and the assert checks need to check these cases. As for the list in the description, personally, I believe it is clear and concise, while helping reinforcing new knowledge through repetition. But more opinions would be great to discuss this issue.

@vaibhav-ace
Copy link
Contributor

I like the description made in this PR because it shows the exact output the user is meant to see and it clearly shows each step and makes it easy to follow too. But happy for any new suggestions too 👍

naomi-lgbt
naomi-lgbt requested changes May 26, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I've landed on what I had in mind for this.

...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
@naomi-lgbt naomi-lgbt added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 26, 2024
cheenu-1824 and others added 4 commits May 27, 2024 16:33
@cheenu-1824 @naomi-lgbt
fixing changes to description as suggested by reviewer
2716c26 
Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@cheenu-1824
Merge remote-tracking branch 'upstream/main' into fix/Add-review-step…
242d488 
…-for-variables-and-console-statements-in-pyramid-project
@cheenu-1824
Merge branch 'fix/Add-review-step-for-variables-and-console-statement…
01d6296 
…s-in-pyramid-project' of https://github.com/cheenu-1824/freeCodeCamp into fix/Add-review-step-for-variables-and-console-statements-in-pyramid-project
@cheenu-1824
fixed issue that caused error in CI/CD
8ad56df
naomi-lgbt
naomi-lgbt approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this!

@cheenu-1824 @lasjorg
Applied further suggestions from code review
9351c22 
Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com>
@cheenu-1824 cheenu-1824 requested a review from lasjorg May 28, 2024 16:54
lasjorg
lasjorg requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@lasjorg lasjorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed some stuff. Also, note my comment on the log tests.

...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed97c55a99e5ffab759dc.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664ed9344ba3495e1f67f8ea.md Outdated Show resolved Hide resolved
cheenu-1824 and others added 2 commits May 29, 2024 03:17
@cheenu-1824 @lasjorg
Applying missing suggestions from a code reviewer
306787a 
Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com>
@cheenu-1824
fix issue with step 13 console log test being unused
efd2f9a
@cheenu-1824 cheenu-1824 requested a review from lasjorg May 28, 2024 18:35
@cheenu-1824
Copy link
Contributor Author

I have included the suggestions and made changes to the issue related to console log tests

lasjorg
lasjorg approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@lasjorg lasjorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now. Thanks for the extra work.

@lasjorg lasjorg merged commit 8766a3b into freeCodeCamp:main May 28, 2024
21 checks passed
@cheenu-1824 cheenu-1824 deleted the fix/Add-review-step-for-variables-and-console-statements-in-pyramid-project branch May 29, 2024 07:56
@ilenia-magoni ilenia-magoni removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasjorg lasjorg lasjorg approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add review step for variables and console statements in pyramid project
7 participants
@cheenu-1824 @vaibhav-ace @lasjorg @naomi-lgbt @moT01 @huyenltnguyen @ilenia-magoni