Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): unsubscribe all subscribed emails #54953

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ShaunSHamilton
Copy link
Member

Checklist:

Related #40773 (Only to be closed, once new api is deployed)

Before After
Unsubscribing accounts with the same email but different unsubscribeIds would result in emails still being sent Unsubscribing accounts with the same email but different unsubscribeIds unsubscribes all accounts
All accounts with same unsubscribeId get unsubscribed All accounts with same unsubscribeId get unsubscribed

These changes could be backported to the old/current api. However, I find it unscrupulous.

@ShaunSHamilton ShaunSHamilton requested a review from a team as a code owner May 23, 2024 15:56
@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label May 23, 2024
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but why not both unsubscribeId and email? The chance of duplicate ids is low, but it should be quick to do both (assuming indexes are correct). Nevermind, I see it now!

@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 24, 2024
@moT01 moT01 enabled auto-merge (squash) June 10, 2024 20:58
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moT01 moT01 merged commit 63a3b8a into freeCodeCamp:main Jun 11, 2024
22 checks passed
@ShaunSHamilton ShaunSHamilton deleted the fix_unsub-all branch June 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants