-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UI): minimize the fixed contents upper the editor #54978
fix(UI): minimize the fixed contents upper the editor #54978
Conversation
@ahmaxed Can you take a look at this? |
This is definitely an improvement. At 400% zoom (e.g. 320x256 px viewport) I can see about 4.5 lines of code instead of three, so we gained almost two lines. I'm wondering if we can do better. We could remove some of the top/bottom padding around both the tablist and file buttons. And we could remove some of the top/bottom padding in the tabs and buttons themselves. Yes, things will be a little more scrunched up in the header, but at such extremes zoom levels I think that editor space is more important than aesthetics. We could make these more extreme changes a smaller height, such as beginning at 600 or even 500px. |
Thanks for your review and comment, @bbsmooth.
I definitely agree with you. Although, as you mentioned, with removing the paddings, the fixed contents above the editor will be scrunched up, and I personally think that this will increase the possibility that users will tap the unintended button or tab on ordinary small devices, which can reduce usability. Therefore, the The
I think the thresh value should receive more thorough review, as I have only used Android Studio's emulator and Chrome's mobile simulator to determine this value. With removing some of the paddings, the camper can see six lines of code when opening the multifile editor and zoomed in 400% as shown in below image. |
Thanks for your review, @ahmaxed. The two issues you mentioned are occured with my misunderstanding of latest original issue report of yours, especially |
This feature would go greatly with a unit test so we could lock it in. |
I'm not sure whether this is the best approach, with using the |
I will leave this one to our playwright expert: @Sembauke. Bootstrap has just been removed so I recommend merging main and resolving the conflicts. Other than that this should be good to go. |
Checklist:
main
branch of freeCodeCamp.Partially address issues #53660 and #49054
This PR was opened to minimize the fixed contents upper the editor such as breadcrumb and a file display button in
monaco-editor-tabs
inStep
challenges so that partially addressing the original issues as first step.When the
viewport height is equal to or less thanmobile layout is displayed, the breadcrumb upper the editor moves into the600px900pxdescription-container
in theStep
challenges.On the other hand, if there is only one file to display on mobile layout,
monaco-editor-tabs
will be empty and the button to switch the file display will not be displayed .By using gitpod, the code was tested with following environment.