Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Top Learn to Solve Problems and Understand Errors #55027

Merged
merged 15 commits into from
Jun 20, 2024
Merged

feat: Top Learn to Solve Problems and Understand Errors #55027

merged 15 commits into from
Jun 20, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 30, 2024 •
edited
Loading

Checklist:

Closes #XXXXX

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 30, 2024
@Sembauke Sembauke mentioned this pull request Jun 3, 2024
Merged
4 tasks
@Sembauke Sembauke marked this pull request as ready for review June 10, 2024 10:33
@Sembauke Sembauke requested a review from a team as a code owner June 10, 2024 10:33
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 10, 2024
naomi-lgbt
naomi-lgbt requested changes Jun 10, 2024
View reviewed changes
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-a.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-d.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-e.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-e.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-f.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-f.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-g.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-g.md Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-h.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-h.md Outdated Show resolved Hide resolved
Sembauke and others added 2 commits June 10, 2024 20:48
@Sembauke @naomi-lgbt
Apply suggestions from code review
5e94637 
Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
@Sembauke
fix: question G
e04b94c
moT01
moT01 requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one minor spacing issue.

I noticed a bunch of quotes and apostrophe's that look like they were copy/pasted from somewhere. They're the curved ones instead of the straight ones - that bothers me, but it's fine.

One other thing I noticed was that the images extend beyond the columns:

Screenshot 2024-06-20 at 12 49 19 PM

I made suggestions to adjust the inline width styles, which fixes the issue, but makes the image in question E a little small:

Screenshot 2024-06-20 at 1 00 29 PM

Not sure if we want to make those adjustments here, or maybe get some new screenshots or what. I think we would be fine with it a little small for now. What do you think @Sembauke?

...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-f.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-e.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-f.md Outdated Show resolved Hide resolved
...e-problems-and-understand-errors/learn-to-solve-problems-and-understand-errors-question-g.md Outdated Show resolved Hide resolved
@Sembauke @moT01
Apply suggestions from code review
16a875f 
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
@Sembauke Sembauke requested a review from moT01 June 20, 2024 19:35
@moT01 moT01 merged commit 27c4957 into freeCodeCamp:main Jun 20, 2024
17 checks passed
@Sembauke Sembauke deleted the feat/top-learn-to-solve-problems-and-understand-errors branch June 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sembauke @moT01 @naomi-lgbt