Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): New steps to teach lists #55167

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): New steps to teach lists #55167

wants to merge 11 commits into from
+699 −148

Conversation

ilenia-magoni
Copy link
Contributor

@ilenia-magoni ilenia-magoni commented Jun 12, 2024 •
edited

Checklist:

Closes #55084

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Jun 12, 2024
@Dario-DC Dario-DC changed the title [skip ci] New steps to teach lists feat(curriculum): New steps to teach lists Jun 12, 2024
Dario-DC
Dario-DC reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps 10 and 11 (introducing lists and append) should be adjusted considering the new steps.

...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694eaaeb7d253049fa7883.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694bfa435cef241f6f9a68.md Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694fc4bba24f33ca01fa5b.md Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666951d2e4b27e3a3c72ca5f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666951d2e4b27e3a3c72ca5f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666951d2e4b27e3a3c72ca5f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/6669539c1379793f9cb8917c.md Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666aae6a5d30a71f1fd7749f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666aae6a5d30a71f1fd7749f.md Outdated Show resolved Hide resolved
@ilenia-magoni ilenia-magoni marked this pull request as ready for review June 21, 2024 15:42
@ilenia-magoni ilenia-magoni requested a review from a team as a code owner June 21, 2024 15:42
Dario-DC
Dario-DC reviewed Jun 22, 2024
View reviewed changes
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694bfa435cef241f6f9a68.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694eaaeb7d253049fa7883.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694eaaeb7d253049fa7883.md

# --description--

To add items to a list, you can write them between the parenthesis. Add the numbers `1` and `2` inside the list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I would mention again to use the comma to separate the values.

...ith-python/learn-lambda-functions-by-building-an-expense-tracker/66694fc4bba24f33ca01fa5b.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666951d2e4b27e3a3c72ca5f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666aae6a5d30a71f1fd7749f.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666aae6a5d30a71f1fd7749f.md
print(example_list) # [4, 5, 5.5, 6, 7]
```

The `my_list` list is missing the `1` now. Add it using `insert()` in the right position, then print the list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should say something more precise if we want the list to be ordered. Although is pretty intuitive.

...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666ab82c874add3c95145213.md Outdated Show resolved Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666ab82c874add3c95145213.md

fruits_list.pop(2)

print(fruits_list) # ["cherry", "lemon", "apple", "orange"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so glad you removed "tomato".

...ith-python/learn-lambda-functions-by-building-an-expense-tracker/666ab82c874add3c95145213.md Outdated Show resolved Hide resolved
@ilenia-magoni @naomi-lgbt @Dario-DC
Apply suggestions from code review
ebd60d6 
Co-authored-by: Naomi <accounts+github@nhcarrigan.com>
Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
zairahira
zairahira reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@zairahira zairahira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new instructions look great.
I think specifying that lists are mutable would be beneficial to campers.

...ith-python/learn-lambda-functions-by-building-an-expense-tracker/6669539c1379793f9cb8917c.md

# --description--

Another thing you can do with bracket notation is change an element value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Another thing you can do with bracket notation is change an element value.
Python lists are mutable which means that the value of the list items can be changed.
You can change an element's value using the bracket notation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zairahira zairahira zairahira left review comments

@naomi-lgbt naomi-lgbt naomi-lgbt left review comments

@Dario-DC Dario-DC Dario-DC left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor list introduction in Expense Tracker project of SCWP
4 participants
@ilenia-magoni @zairahira @naomi-lgbt @Dario-DC