Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum/ python): italicize definition case convertor project #55180

Conversation

zairahira
Copy link
Member

Checklist:

Related to #55111

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 13, 2024
@zairahira zairahira changed the title fix: italicize definition fix(curriculum/ python): italicize definition Jun 13, 2024
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the syntax in the paragraph definition

Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that maybe we could think of moving the definition to the step in which list comprehensions are actually used. This is step 19 (#54051)

A list comprehension is a concise way to create lists in Python. A basic list comprehension consists of an expression followed by a `for` clause:
```py
spam = [i * 2 for i in iterable]
```
The above uses the variable `i` to iterate over `iterable`. Each elements of the resulting list is obtained by evaluating the expression `i * 2` at the current iteration.

I'm not sure if that would better better.

@zairahira
Copy link
Member Author

zairahira commented Jun 14, 2024

I was thinking that maybe we could think of moving the definition to the step in which list comprehensions are actually used. This is step 19 (#54051)

A list comprehension is a concise way to create lists in Python. A basic list comprehension consists of an expression followed by a `for` clause:
```py
spam = [i * 2 for i in iterable]
```
The above uses the variable `i` to iterate over `iterable`. Each elements of the resulting list is obtained by evaluating the expression `i * 2` at the current iteration.

I'm not sure if that would better better.

I was thinking the same.

I was thinking the same.
Instead of step 19, how about introducing list comprehension in step 15?

@zairahira
Copy link
Member Author

Also, step 18 and 19 have tracebacks in the console that weren't addressed.

@Dario-DC
Copy link
Contributor

Also, step 18 and 19 have tracebacks in the console that weren't addressed.

After Lary's PR will be merged there won't be any.

@zairahira
Copy link
Member Author

Also, step 18 and 19 have tracebacks in the console that weren't addressed.

After Lary's PR will be merged there won't be any.

Step 19 from the new changes would be a good place to introduce list comprehensions.
I'll wait till that PR is merged and then work on this PR.

@Dario-DC
Copy link
Contributor

I hit 'edit' instead of 'quote reply' on one of your previous comment 😅 sorry about the confusion @zairahira
So, do we all agree on moving the definition in step 19?

@zairahira zairahira marked this pull request as ready for review June 14, 2024 13:18
@zairahira zairahira changed the title fix(curriculum/ python): italicize definition fix(curriculum/ python): italicize definition case convertor project Jun 14, 2024
@zairahira zairahira requested review from ilenia-magoni, Dario-DC and a team June 20, 2024 07:17
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I would argue that list comprehensions don't improve readability 😜

zairahira and others added 2 commits June 20, 2024 16:37
Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
@zairahira zairahira requested a review from Dario-DC June 24, 2024 07:40
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Do we need to add any other definition for this project?

@ilenia-magoni ilenia-magoni enabled auto-merge (squash) June 24, 2024 09:43
@ilenia-magoni ilenia-magoni merged commit b93c80b into freeCodeCamp:main Jun 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants