Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the typecheck errors caused by "browserName" #55236

Closed
wants to merge 1 commit into from

Conversation

swarupn17
Copy link

@swarupn17 swarupn17 commented Jun 20, 2024

Checklist:

Closes #XXXXX

@swarupn17 swarupn17 requested a review from a team as a code owner June 20, 2024 06:58
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Jun 20, 2024
@camperbot
Copy link
Contributor

Hello,

Firstly, thank you for submitting this pull request!

As you navigate through the process, we have a PR checklist to ensure consistency and quality in our contributions. We kindly ask that you genuinely follow through with each point. This not only facilitates the review process but also demonstrates a mutual respect for the community's efforts.

If you're unfamiliar with certain aspects, our contributing guidelines are a helpful resource to get you up to speed.

**Friendly Pointers (click to expand)**
  1. Editing on GitHub: While it's possible to edit files directly on GitHub, it's typically better not to. This helps avoid inadvertent mistakes like typos that can disrupt tests.

  2. Pull Request Title: Please ensure the PR title follows our convention.

  3. Linking Issues: Please ensure you link issues using the designated method. Simply update the XXXXXX in the PR description to include the issue number. This keeps our records organized and clear.

  4. Engaging with the Team: We know you're eager, but kindly keep mentions and review requests limited. Our maintainers are always on the lookout and will attend to PRs in the order they come in.

  5. Branch Management: It's a good practice not to work directly off your main branch. Creating separate branches for different changes allows you to smoothly update your PR even as the main repository progresses.

Please note, there's no need to close this PR. If you have questions or need guidance refining your contribution, don't hesitate to ask. Our community is here to assist.

Thank you for your enthusiasm in contributing to our project. We eagerly await more contributions from you!

Happy Contributing! 🌟

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 20, 2024
@camperbot
Copy link
Contributor

Thank you for opening this pull request.

This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.

Thank you and happy coding.

@camperbot camperbot closed this Jun 21, 2024
@ilenia-magoni ilenia-magoni removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants