Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): remove browserName from the focusEditor calls #55246

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

aliharis99
Copy link
Contributor

Checklist:

Closes #55232

@aliharis99 aliharis99 requested a review from a team as a code owner June 20, 2024 20:45
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Jun 20, 2024
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement is only removing browserName from focusEditor calls.

Please keep the other functions as is.

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 21, 2024
@huyenltnguyen huyenltnguyen self-assigned this Jun 21, 2024
@huyenltnguyen
Copy link
Member

Thanks for addressing the feedback. We're close.

browserName is now an unused variable here: https://github.com/freeCodeCamp/freeCodeCamp/pull/55246/files#diff-7bcc7e0b7d5a4a4c73ec6a263b7e3b3a0edc66c798bea820051c2c689ec806c2R26. And it should be removed.

e2e/editor.spec.ts Outdated Show resolved Hide resolved
@huyenltnguyen huyenltnguyen changed the title fix: removed browserName from the function files fix(e2e): removed browserName from the function files Jun 21, 2024
@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Jun 21, 2024
@huyenltnguyen huyenltnguyen removed their assignment Jun 21, 2024
Copy link
Member

@gikf gikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future - it is recommended to make changes on a separate branch, rather than the main branch. See more about it in point 3 at https://contribute.freecodecamp.org/#/how-to-contribute-to-the-codebase?id=contributing-to-the-codebase.

@Sembauke Sembauke enabled auto-merge (squash) June 21, 2024 15:41
@gikf gikf changed the title fix(e2e): removed browserName from the function files fix(e2e): remove browserName from the focusEditor calls Jun 21, 2024
@Sembauke Sembauke merged commit f8d8858 into freeCodeCamp:main Jun 21, 2024
16 of 17 checks passed
@ilenia-magoni ilenia-magoni removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typecheck error in editor tests
5 participants